From: Aakash Hemadri <aakashhemadri123@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic
Date: Sat, 28 Aug 2021 14:15:28 +0530 [thread overview]
Message-ID: <20210828084528.gbkqcgqaaf3adyb7@xps.yggdrasil> (raw)
In-Reply-To: <f2ab21eab23c4863b1b5c004a75d834d@AcuMS.aculab.com>
On 21/08/25 09:23AM, David Laight wrote:
> From: Aakash Hemadri
> > Sent: 23 August 2021 18:00
> >
> > Fix sparse warning:
> > > rtw_br_ext.c:771:84: got restricted __be16 [usertype] payload_len
> > > rtw_br_ext.c:773:110: warning: incorrect type in argument 2
> > (different base types)
> > > rtw_br_ext.c:773:110: expected int len
> > > rtw_br_ext.c:773:110: got restricted __be16 [usertype] payload_len
> >
> > csum_ipv6_magic and csum_partial expect int len not __be16, use
> > be16_to_cpu()
>
> This is a behaviour change on LE systems.
> Even if you are testing on BE the commit message should say
> that it fixes the length passed to the checksum code and
> was detected by sparse.
>
Thanks for the note david.
-Aakash
next prev parent reply other threads:[~2021-08-28 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 17:00 [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 1/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 2/5] staging: r8188eu: cast to restricted __be32 Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-25 9:23 ` David Laight
2021-08-28 8:45 ` Aakash Hemadri [this message]
2021-08-23 17:00 ` [PATCH v4 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-08-28 8:50 ` [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-28 9:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210828084528.gbkqcgqaaf3adyb7@xps.yggdrasil \
--to=aakashhemadri123@gmail.com \
--cc=David.Laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).