From: Alan Stern <stern@rowland.harvard.edu>
To: Evgeny Novikov <novikov@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Lunn <andrew@lunn.ch>,
Mike Turquette <mturquette@linaro.org>,
Kirill Shilimanov <kirill.shilimanov@huawei.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe
Date: Sat, 28 Aug 2021 11:11:46 -0400 [thread overview]
Message-ID: <20210828151146.GA288644@rowland.harvard.edu> (raw)
In-Reply-To: <303a5695-e0c4-1cae-ee1f-6f34a9717b77@ispras.ru>
On Sat, Aug 28, 2021 at 01:47:12PM +0300, Evgeny Novikov wrote:
> Hi Alan,
>
> On 26.08.2021 18:24, Alan Stern wrote:
> > I don't know whether these errors can occur or not. To find out, you need to
> > ask someone who knows more about the clock framework.
> >
> > On the other hand, the fact that the functions do return an error code means
> > that they expect callers to check its value. In fact, whoever changed the API
> > should have gone through all the callers to make sure they did so.
> >
> > (Let's put it this way: If those functions can return an error, we should
> > check the return code. If they can't return an error then they shouldn't be
> > defined to return an int, so the API should be changed.)
> >
> > So on the whole, I think making these changes would be a good thing. At the
> > very least, it will help make all the different EHCI and OHCI drivers
> > consistent with each other.
> Though I may be wrong, but after the discussion with Dan, it does not seem
> that we can expect any considerable changes in the clock API and support
> from the static analysis tools soon. So, if you still would like to see
> corresponding fixes in EHCI and OHCI drivers, I can prepare them.
Yes, please do so.
Alan Stern
next prev parent reply other threads:[~2021-08-28 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 17:09 [PATCH] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe Evgeny Novikov
2021-08-25 17:29 ` Alan Stern
2021-08-26 13:30 ` Evgeny Novikov
2021-08-26 15:24 ` Alan Stern
2021-08-26 16:26 ` Evgeny Novikov
2021-08-27 11:51 ` Dan Carpenter
2021-08-28 10:37 ` Evgeny Novikov
2021-08-28 10:47 ` Evgeny Novikov
2021-08-28 15:11 ` Alan Stern [this message]
2021-08-25 17:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210828151146.GA288644@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shilimanov@huawei.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=novikov@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).