From: Andrew Lunn <andrew@lunn.ch>
To: Evgeny Novikov <novikov@ispras.ru>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Turquette <mturquette@linaro.org>,
Kirill Shilimanov <kirill.shilimanov@huawei.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe
Date: Wed, 25 Aug 2021 19:33:09 +0200 [thread overview]
Message-ID: <YSZ+1bFUEMsJlrcu@lunn.ch> (raw)
In-Reply-To: <20210825170902.11234-1-novikov@ispras.ru>
On Wed, Aug 25, 2021 at 08:09:02PM +0300, Evgeny Novikov wrote:
> ehci_orion_drv_probe() did not account for possible errors of
> clk_prepare_enable()
Hi Evgeny
Your patch looks good.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
At the time this was added, clk_prepare_enable() could not actually
fail, the clocks are built in, there was no error path that could
trigger. I've no idea if this is still true, so please do have this
patch merged.
Andrew
prev parent reply other threads:[~2021-08-25 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 17:09 [PATCH] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe Evgeny Novikov
2021-08-25 17:29 ` Alan Stern
2021-08-26 13:30 ` Evgeny Novikov
2021-08-26 15:24 ` Alan Stern
2021-08-26 16:26 ` Evgeny Novikov
2021-08-27 11:51 ` Dan Carpenter
2021-08-28 10:37 ` Evgeny Novikov
2021-08-28 10:47 ` Evgeny Novikov
2021-08-28 15:11 ` Alan Stern
2021-08-25 17:33 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSZ+1bFUEMsJlrcu@lunn.ch \
--to=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shilimanov@huawei.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=novikov@ispras.ru \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).