* [PATCH] mmc: mtk-sd: Remove unused parameters [not found] <CGME20210830022507epcas1p43b45563c6e36bd00e3b6160bb42605bf@epcas1p4.samsung.com> @ 2021-08-30 2:17 ` Chanwoo Lee 2021-09-06 17:10 ` Ulf Hansson 0 siblings, 1 reply; 2+ messages in thread From: Chanwoo Lee @ 2021-08-30 2:17 UTC (permalink / raw) To: chaotian.jing, ulf.hansson, matthias.bgg, linux-mmc, linux-kernel, linux-arm-kernel, linux-mediatek Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee, ChanWoo Lee From: ChanWoo Lee <cw9316.lee@samsung.com> Remove unused parameters 1. msdc_start_data() - struct mmc_request *mrq 2. msdc_track_cmd_data() - struct mmc_data *data Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com> --- drivers/mmc/host/mtk-sd.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 4dfc246c5f95..a8736067c409 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1043,8 +1043,8 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host, return rawcmd; } -static void msdc_start_data(struct msdc_host *host, struct mmc_request *mrq, - struct mmc_command *cmd, struct mmc_data *data) +static void msdc_start_data(struct msdc_host *host, struct mmc_command *cmd, + struct mmc_data *data) { bool read; @@ -1112,8 +1112,7 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host) } } -static void msdc_track_cmd_data(struct msdc_host *host, - struct mmc_command *cmd, struct mmc_data *data) +static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd) { if (host->error) dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", @@ -1134,7 +1133,7 @@ static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq) host->mrq = NULL; spin_unlock_irqrestore(&host->lock, flags); - msdc_track_cmd_data(host, mrq->cmd, mrq->data); + msdc_track_cmd_data(host, mrq->cmd); if (mrq->data) msdc_unprepare_data(host, mrq->data); if (host->error) @@ -1295,7 +1294,7 @@ static void msdc_cmd_next(struct msdc_host *host, else if (!cmd->data) msdc_request_done(host, mrq); else - msdc_start_data(host, mrq, cmd, cmd->data); + msdc_start_data(host, cmd, cmd->data); } static void msdc_ops_request(struct mmc_host *mmc, struct mmc_request *mrq) -- 2.29.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mtk-sd: Remove unused parameters 2021-08-30 2:17 ` [PATCH] mmc: mtk-sd: Remove unused parameters Chanwoo Lee @ 2021-09-06 17:10 ` Ulf Hansson 0 siblings, 0 replies; 2+ messages in thread From: Ulf Hansson @ 2021-09-06 17:10 UTC (permalink / raw) To: Chanwoo Lee Cc: Chaotian Jing, Matthias Brugger, linux-mmc, Linux Kernel Mailing List, Linux ARM, moderated list:ARM/Mediatek SoC support, grant.jung, jt77.jang, DooHyun Hwang, Seunghui Lee On Mon, 30 Aug 2021 at 04:25, Chanwoo Lee <cw9316.lee@samsung.com> wrote: > > From: ChanWoo Lee <cw9316.lee@samsung.com> > > Remove unused parameters > 1. msdc_start_data() - struct mmc_request *mrq > 2. msdc_track_cmd_data() - struct mmc_data *data > > Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com> Queued for v5.16 on the temporary devel branch, thanks! Kind regards Uffe > --- > drivers/mmc/host/mtk-sd.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 4dfc246c5f95..a8736067c409 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1043,8 +1043,8 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host, > return rawcmd; > } > > -static void msdc_start_data(struct msdc_host *host, struct mmc_request *mrq, > - struct mmc_command *cmd, struct mmc_data *data) > +static void msdc_start_data(struct msdc_host *host, struct mmc_command *cmd, > + struct mmc_data *data) > { > bool read; > > @@ -1112,8 +1112,7 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host) > } > } > > -static void msdc_track_cmd_data(struct msdc_host *host, > - struct mmc_command *cmd, struct mmc_data *data) > +static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd) > { > if (host->error) > dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", > @@ -1134,7 +1133,7 @@ static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq) > host->mrq = NULL; > spin_unlock_irqrestore(&host->lock, flags); > > - msdc_track_cmd_data(host, mrq->cmd, mrq->data); > + msdc_track_cmd_data(host, mrq->cmd); > if (mrq->data) > msdc_unprepare_data(host, mrq->data); > if (host->error) > @@ -1295,7 +1294,7 @@ static void msdc_cmd_next(struct msdc_host *host, > else if (!cmd->data) > msdc_request_done(host, mrq); > else > - msdc_start_data(host, mrq, cmd, cmd->data); > + msdc_start_data(host, cmd, cmd->data); > } > > static void msdc_ops_request(struct mmc_host *mmc, struct mmc_request *mrq) > -- > 2.29.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-06 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210830022507epcas1p43b45563c6e36bd00e3b6160bb42605bf@epcas1p4.samsung.com>
2021-08-30 2:17 ` [PATCH] mmc: mtk-sd: Remove unused parameters Chanwoo Lee
2021-09-06 17:10 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).