From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: "Mihail Chindris" <mihail.chindris@analog.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Bogdan, Dragos" <dragos.bogdan@analog.com>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>
Subject: Re: [PATCH v4 0/6] iio: Add output buffer support and DAC example
Date: Mon, 30 Aug 2021 16:17:30 +0100 [thread overview]
Message-ID: <20210830161730.554e2663@jic23-huawei> (raw)
In-Reply-To: <CA+U=DsqfxUVJ6e_09wWBqP2XMgYrsq0ggOmgFWKzrru45oWZYQ@mail.gmail.com>
On Wed, 25 Aug 2021 10:35:53 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
> On Fri, Aug 20, 2021 at 8:01 PM Mihail Chindris
> <mihail.chindris@analog.com> wrote:
> >
>
> My only note about this series [as a whole] is that I would have
> chosen an existing DAC to which to add kfifo output support.
> To make things smooth for this new mechanism.
>
> A new driver usually takes more effort to review/introduce than a
> change to an existing one.
Agreed. If it makes sense to send the driver without this support
first then add it in a follow up that is fine too. That way we can
separate basic driver review from the exciting new stuff.
Jonathan
>
> > Changelog v3 -> v4:
> > * https://lore.kernel.org/linux-iio/20210219124012.92897-1-alexandru.ardelean@analog.com
> > * Remove DMA related commits
> > * Test and add fixies to the previous version
> > - Add write function to iio_buffer_fileops in industrialiio-core
> > - In iio_kfifo_remove_from change number of samples to 1 instead of
> > r->bytes_per_datum otherwise n square samples are removed.
> > - In iio_buffer_remove_sample replace move buffer->access->write
> > check to first if an replace with remove_from. Checkpatch was
> > complaining about returning -ENOSYS
> > * Add ad3552r example
> >
> > Alexandru Ardelean (1):
> > iio: triggered-buffer: extend support to configure output buffers
> >
> > Lars-Peter Clausen (2):
> > iio: Add output buffer support
> > iio: kfifo-buffer: Add output buffer support
> >
> > Mihail Chindris (3):
> > Documentation:ABI:testing:add doc for AD3552R ABI
> > dt-bindings: iio: dac: Add adi,ad3552r.yaml
> > drivers:iio:dac: Add AD3552R driver support
> >
> > .../ABI/testing/sysfs-bus-iio-dac-ad3552r | 10 +
> > .../bindings/iio/dac/adi,ad3552r.yaml | 185 +++
> > drivers/iio/accel/adxl372.c | 1 +
> > drivers/iio/accel/bmc150-accel-core.c | 1 +
> > drivers/iio/adc/at91-sama5d2_adc.c | 4 +-
> > .../buffer/industrialio-triggered-buffer.c | 8 +-
> > drivers/iio/buffer/kfifo_buf.c | 50 +
> > .../cros_ec_sensors/cros_ec_sensors_core.c | 5 +-
> > .../common/hid-sensors/hid-sensor-trigger.c | 5 +-
> > drivers/iio/dac/Kconfig | 10 +
> > drivers/iio/dac/Makefile | 1 +
> > drivers/iio/dac/ad3552r.c | 1419 +++++++++++++++++
> > drivers/iio/iio_core.h | 4 +
> > drivers/iio/industrialio-buffer.c | 133 +-
> > drivers/iio/industrialio-core.c | 1 +
> > include/linux/iio/buffer.h | 7 +
> > include/linux/iio/buffer_impl.h | 11 +
> > include/linux/iio/triggered_buffer.h | 11 +-
> > 18 files changed, 1854 insertions(+), 12 deletions(-)
> > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r
> > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> > create mode 100644 drivers/iio/dac/ad3552r.c
> >
> >
> > base-commit: 94a853eca720ac9e385e59f27e859b4a01123f58
> > --
> > 2.27.0
> >
prev parent reply other threads:[~2021-08-30 15:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 16:59 [PATCH v4 0/6] iio: Add output buffer support and DAC example Mihail Chindris
2021-08-20 16:59 ` [PATCH v4 1/6] iio: Add output buffer support Mihail Chindris
2021-08-21 0:24 ` kernel test robot
2021-08-23 2:23 ` kernel test robot
2021-08-23 13:50 ` Nuno Sá
2021-08-30 15:42 ` Jonathan Cameron
2021-09-01 8:50 ` Sa, Nuno
2021-09-05 9:54 ` Jonathan Cameron
2021-08-25 8:35 ` Alexandru Ardelean
2021-08-30 16:05 ` Jonathan Cameron
2021-09-01 8:54 ` Sa, Nuno
2021-09-05 9:55 ` Jonathan Cameron
2021-09-16 10:57 ` Chindris, Mihail
2021-08-20 16:59 ` [PATCH v4 2/6] iio: kfifo-buffer: " Mihail Chindris
2021-08-21 14:15 ` kernel test robot
2021-08-23 13:51 ` Nuno Sá
2021-08-20 16:59 ` [PATCH v4 3/6] iio: triggered-buffer: extend support to configure output buffers Mihail Chindris
2021-08-21 3:28 ` kernel test robot
2021-08-20 16:59 ` [PATCH v4 4/6] Documentation:ABI:testing:add doc for AD3552R ABI Mihail Chindris
2021-08-30 15:22 ` Jonathan Cameron
2021-08-20 16:59 ` [PATCH v4 5/6] dt-bindings: iio: dac: Add adi,ad3552r.yaml Mihail Chindris
2021-08-30 15:37 ` Jonathan Cameron
2021-08-20 16:59 ` [PATCH v4 6/6] drivers:iio:dac: Add AD3552R driver support Mihail Chindris
2021-08-20 19:55 ` kernel test robot
2021-08-20 22:15 ` kernel test robot
2021-08-23 14:01 ` Nuno Sá
2021-08-30 16:54 ` Jonathan Cameron
2021-08-25 7:35 ` [PATCH v4 0/6] iio: Add output buffer support and DAC example Alexandru Ardelean
2021-08-30 15:17 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830161730.554e2663@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=dragos.bogdan@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihail.chindris@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).