From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Josh Don <joshdon@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Paul Turner <pjt@google.com>, Oleg Rombakh <olegrom@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steve Sistare <steven.sistare@oracle.com>,
Tejun Heo <tj@kernel.org>, Rik van Riel <riel@surriel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] sched: cgroup SCHED_IDLE support
Date: Wed, 1 Sep 2021 21:22:06 -0400 [thread overview]
Message-ID: <20210902012206.cm6flytlp63c2h5v@oracle.com> (raw)
In-Reply-To: <20210820010403.946838-2-joshdon@google.com>
On Thu, Aug 19, 2021 at 06:04:00PM -0700, Josh Don wrote:
> +static int se_is_idle(struct sched_entity *se)
> +{
> + return 0;
> +}
I'm thinking !FAIR_GROUP_SCHED is a rare thing to behold? So not a big
deal, but I think this wants to be
return task_has_idle_policy(task_of(se));
so buddies aren't set for SCHED_IDLE.
> static void set_last_buddy(struct sched_entity *se)
> {
> - if (entity_is_task(se) && unlikely(task_has_idle_policy(task_of(se))))
> - return;
> -
> for_each_sched_entity(se) {
> if (SCHED_WARN_ON(!se->on_rq))
> return;
> + if (se_is_idle(se))
> + return;
> cfs_rq_of(se)->last = se;
> }
> }
>
> static void set_next_buddy(struct sched_entity *se)
> {
> - if (entity_is_task(se) && unlikely(task_has_idle_policy(task_of(se))))
> - return;
> -
> for_each_sched_entity(se) {
> if (SCHED_WARN_ON(!se->on_rq))
> return;
> + if (se_is_idle(se))
> + return;
> cfs_rq_of(se)->next = se;
> }
> }
next prev parent reply other threads:[~2021-09-02 1:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 1:03 [PATCH v3 0/4] SCHED_IDLE extensions Josh Don
2021-08-20 1:04 ` [PATCH v3 2/4] sched: account number of SCHED_IDLE entities on each cfs_rq Josh Don
2021-08-24 7:57 ` Vincent Guittot
2021-09-09 11:18 ` [tip: sched/core] sched: Account " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 3/4] sched: reduce sched slice for SCHED_IDLE entities Josh Don
2021-08-23 10:08 ` Vincent Guittot
2021-08-23 17:40 ` Josh Don
2021-08-24 7:56 ` Vincent Guittot
2021-08-24 10:24 ` Jiang Biao
2021-08-24 17:04 ` Josh Don
2021-08-25 2:43 ` Jiang Biao
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 4/4] sched: adjust sleeper credit " Josh Don
2021-08-23 10:09 ` Vincent Guittot
2021-08-24 8:16 ` Jiang Biao
2021-08-24 17:12 ` Josh Don
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
[not found] ` <20210906124702.Q6G0oOWwFOmQSl_jmRms3XQgfz4ROzfE71r3SNgWSf0@z>
2021-09-06 12:47 ` [PATCH v3 1/4] sched: cgroup SCHED_IDLE support alexs
2021-08-20 8:39 ` Tao Zhou
2021-08-23 17:29 ` Josh Don
2021-08-23 22:45 ` Tao Zhou
2021-09-02 1:22 ` Daniel Jordan [this message]
2021-09-03 1:21 ` Josh Don
2021-09-08 20:38 ` Daniel Jordan
2021-09-08 18:36 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902012206.cm6flytlp63c2h5v@oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=olegrom@google.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).