From: Josh Don <joshdon@google.com>
To: Jiang Biao <benbjiang@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Paul Turner <pjt@google.com>, Oleg Rombakh <olegrom@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steve Sistare <steven.sistare@oracle.com>,
Tejun Heo <tj@kernel.org>, Rik van Riel <riel@surriel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] sched: adjust sleeper credit for SCHED_IDLE entities
Date: Tue, 24 Aug 2021 10:12:14 -0700 [thread overview]
Message-ID: <CABk29NtWw53a8CWz4gDc1d57BwNyN1=uiGnSKbdxkGijs__1tg@mail.gmail.com> (raw)
In-Reply-To: <CAPJCdBnz7AzAWyD5Sqc4TLy3By1k4PAex8kpaWrcJb=YPwVC8w@mail.gmail.com>
On Tue, Aug 24, 2021 at 1:16 AM Jiang Biao <benbjiang@gmail.com> wrote:
>
> Hi,
>
> On Fri, 20 Aug 2021 at 09:06, Josh Don <joshdon@google.com> wrote:
> >
> > Give reduced sleeper credit to SCHED_IDLE entities. As a result, woken
> > SCHED_IDLE entities will take longer to preempt normal entities.
> >
> > The benefit of this change is to make it less likely that a newly woken
> > SCHED_IDLE entity will preempt a short-running normal entity before it
> > blocks.
> >
> > We still give a small sleeper credit to SCHED_IDLE entities, so that
> > idle<->idle competition retains some fairness.
> >
> > Example: With HZ=1000, spawned four threads affined to one cpu, one of
> > which was set to SCHED_IDLE. Without this patch, wakeup latency for the
> > SCHED_IDLE thread was ~1-2ms, with the patch the wakeup latency was
> > ~5ms.
> >
> > Signed-off-by: Josh Don <joshdon@google.com>
> Tried to push a similar patch before, but failed. :)
> https://lkml.org/lkml/2020/8/20/1773
> Please pick my Reviewed-by if you don't mind,
> Reviewed-by: Jiang Biao <benbjiang@tencent.com>
Done, thanks :)
next prev parent reply other threads:[~2021-08-24 17:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 1:03 [PATCH v3 0/4] SCHED_IDLE extensions Josh Don
2021-08-20 1:04 ` [PATCH v3 2/4] sched: account number of SCHED_IDLE entities on each cfs_rq Josh Don
2021-08-24 7:57 ` Vincent Guittot
2021-09-09 11:18 ` [tip: sched/core] sched: Account " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 3/4] sched: reduce sched slice for SCHED_IDLE entities Josh Don
2021-08-23 10:08 ` Vincent Guittot
2021-08-23 17:40 ` Josh Don
2021-08-24 7:56 ` Vincent Guittot
2021-08-24 10:24 ` Jiang Biao
2021-08-24 17:04 ` Josh Don
2021-08-25 2:43 ` Jiang Biao
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 4/4] sched: adjust sleeper credit " Josh Don
2021-08-23 10:09 ` Vincent Guittot
2021-08-24 8:16 ` Jiang Biao
2021-08-24 17:12 ` Josh Don [this message]
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
[not found] ` <20210906124702.Q6G0oOWwFOmQSl_jmRms3XQgfz4ROzfE71r3SNgWSf0@z>
2021-09-06 12:47 ` [PATCH v3 1/4] sched: cgroup SCHED_IDLE support alexs
2021-08-20 8:39 ` Tao Zhou
2021-08-23 17:29 ` Josh Don
2021-08-23 22:45 ` Tao Zhou
2021-09-02 1:22 ` Daniel Jordan
2021-09-03 1:21 ` Josh Don
2021-09-08 20:38 ` Daniel Jordan
2021-09-08 18:36 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABk29NtWw53a8CWz4gDc1d57BwNyN1=uiGnSKbdxkGijs__1tg@mail.gmail.com' \
--to=joshdon@google.com \
--cc=benbjiang@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=olegrom@google.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).