From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Subject: [RFC PATCH 0/3] KVM: nSVM: avoid TOC/TOU race when checking vmcb12
Date: Fri, 3 Sep 2021 12:20:36 +0200 [thread overview]
Message-ID: <20210903102039.55422-1-eesposit@redhat.com> (raw)
Currently there is a TOC/TOU race between the check of vmcb12's
efer, cr0 and cr4 registers and the later save of their values in
svm_set_*, because the guest could modify the values in the meanwhile.
To solve this issue, this serie introuces and uses svm->nested.save
structure in enter_svm_guest_mode to save the current value of efer,
cr0 and cr4 and later use these to set the vcpu->arch.* state.
Patch 1 just refactor the code to simplify the next two patches,
patch 2 introduces svm->nested.save to cache the efer, cr0 and cr4 fields
and in patch 3 we use it to avoid TOC/TOU races.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
v1 -> RFC:
- use svm->nested.save instead of local variables.
- not dependent anymore from "KVM: nSVM: remove useless kvm_clear_*_queue"
- simplified patches, we just use the struct and not move the check
nearer to the TOU.
Emanuele Giuseppe Esposito (3):
KVM: nSVM: move nested_vmcb_check_cr3_cr4 logic in
nested_vmcb_valid_sregs
nSVM: introduce smv->nested.save to cache save area fields
nSVM: use svm->nested.save to load vmcb12 registers and avoid TOC/TOU
races
arch/x86/kvm/svm/nested.c | 82 ++++++++++++++++++++-------------------
arch/x86/kvm/svm/svm.c | 1 +
arch/x86/kvm/svm/svm.h | 3 ++
3 files changed, 47 insertions(+), 39 deletions(-)
--
2.27.0
next reply other threads:[~2021-09-03 10:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 10:20 Emanuele Giuseppe Esposito [this message]
2021-09-03 10:20 ` [RFC PATCH 1/3] KVM: nSVM: move nested_vmcb_check_cr3_cr4 logic in nested_vmcb_valid_sregs Emanuele Giuseppe Esposito
2021-09-12 10:36 ` Maxim Levitsky
2021-09-03 10:20 ` [RFC PATCH 2/3] nSVM: introduce smv->nested.save to cache save area fields Emanuele Giuseppe Esposito
2021-09-12 10:39 ` Maxim Levitsky
2021-09-28 16:20 ` Paolo Bonzini
2021-09-28 22:23 ` Sean Christopherson
2021-09-29 11:13 ` Paolo Bonzini
2021-09-03 10:20 ` [RFC PATCH 3/3] nSVM: use svm->nested.save to load vmcb12 registers and avoid TOC/TOU races Emanuele Giuseppe Esposito
2021-09-12 10:42 ` Maxim Levitsky
2021-09-14 8:20 ` Emanuele Giuseppe Esposito
2021-09-14 9:02 ` Maxim Levitsky
2021-09-14 9:12 ` Maxim Levitsky
2021-09-14 9:24 ` Emanuele Giuseppe Esposito
2021-09-14 9:34 ` Maxim Levitsky
2021-09-14 10:52 ` Emanuele Giuseppe Esposito
2021-09-14 11:39 ` Maxim Levitsky
2021-09-28 16:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903102039.55422-1-eesposit@redhat.com \
--to=eesposit@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).