From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] nSVM: use svm->nested.save to load vmcb12 registers and avoid TOC/TOU races
Date: Tue, 28 Sep 2021 18:21:29 +0200 [thread overview]
Message-ID: <4a4c7e3d-5823-6b19-3fd8-e4accf53f28f@redhat.com> (raw)
In-Reply-To: <2b1e17416cef1e37f42e9bc8b2283b03d2651cb2.camel@redhat.com>
On 14/09/21 11:12, Maxim Levitsky wrote:
> But actually that you mention it, I'll say why not to create vmcb_control_area_cached
> as well indeed and change the type of svm->nested.save to it. (in a separate patch)
I think you should have two structs, struct vmcb12_control_area_cache
and struct vmcb12_save_area_cache. Otherwise the two series that
Emanuele posted are nice and can be combined into just one.
Paolo
prev parent reply other threads:[~2021-09-28 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 10:20 [RFC PATCH 0/3] KVM: nSVM: avoid TOC/TOU race when checking vmcb12 Emanuele Giuseppe Esposito
2021-09-03 10:20 ` [RFC PATCH 1/3] KVM: nSVM: move nested_vmcb_check_cr3_cr4 logic in nested_vmcb_valid_sregs Emanuele Giuseppe Esposito
2021-09-12 10:36 ` Maxim Levitsky
2021-09-03 10:20 ` [RFC PATCH 2/3] nSVM: introduce smv->nested.save to cache save area fields Emanuele Giuseppe Esposito
2021-09-12 10:39 ` Maxim Levitsky
2021-09-28 16:20 ` Paolo Bonzini
2021-09-28 22:23 ` Sean Christopherson
2021-09-29 11:13 ` Paolo Bonzini
2021-09-03 10:20 ` [RFC PATCH 3/3] nSVM: use svm->nested.save to load vmcb12 registers and avoid TOC/TOU races Emanuele Giuseppe Esposito
2021-09-12 10:42 ` Maxim Levitsky
2021-09-14 8:20 ` Emanuele Giuseppe Esposito
2021-09-14 9:02 ` Maxim Levitsky
2021-09-14 9:12 ` Maxim Levitsky
2021-09-14 9:24 ` Emanuele Giuseppe Esposito
2021-09-14 9:34 ` Maxim Levitsky
2021-09-14 10:52 ` Emanuele Giuseppe Esposito
2021-09-14 11:39 ` Maxim Levitsky
2021-09-28 16:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4c7e3d-5823-6b19-3fd8-e4accf53f28f@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=eesposit@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).