Re: [PATCH] regulator: core: resolve supply voltage deferral silently

From: Mark Brown <broonie@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: resolve supply voltage deferral silently
Date: Fri, 3 Sep 2021 18:54:14 +0100	[thread overview]
Message-ID: <20210903175414.GO4932@sirena.org.uk> (raw)
In-Reply-To: <CA+ASDXM7GrbahVyneW=TwHi9Uu7sF+7GcC=U0866_m=GXnFmtQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]

On Fri, Sep 03, 2021 at 10:09:04AM -0700, Brian Norris wrote:
> On Fri, Sep 3, 2021 at 4:11 AM Mark Brown <broonie@kernel.org> wrote:

> > In terms of not understanding the issue here is that the patch didn't
> > pass the smell test, it was your explanation that helped here not the
> > pointing at a driver change that lacks obvious relevance.  I really
> > don't know what the reader is supposed to infer about the change from
> > the commit,

> OK, I might see where you're coming from. Personally, I'd still like
> to reference the commit in some way, because I've never used bypass
> mode that I'm aware of, but the mentioned commit added a new case that
> I do care about. I like documenting motivation, where reasonable --
> but apparently I need to do a better job of that part.

A reference is fine - it's just that people actively use Fixes to mean
"the specific commit introduced a bug and anything with the referenced
commit might want this fix" which is different to "The change in this
commit caused me to notice this other thing" which is more what you've
got here.  For this case some words in the commit log saying something
like "The foo change in commit X ($subject) exposed $existing_problem"
is probably what you're looking for.

> > I don't think anyone came up with anything more tasteful to do with that
> > hardware, like I say the hardware is itself very hacky.

> OK. I guess I was specifically asking about this patch (and the new
> usage of ->supply in commit 21e39809fd7c, to some extent). If the
> usage of ->supply is the best we can/should do, then we can leave
> 21e39809fd7c alone. If you don't care to "fix" this log message, then
> I can forget about $subject patch too.

> Or, do you only want me to improve the commit message (drop the Fixes,
> mention bypass mode, etc.) and resubmit?

I've queued it for v5.16, I'm likely to move it to v5.15 - it's just
warnings on a very small subset of systems but OTOH it's pretty safe.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]