linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: resolve supply voltage deferral silently
Date: Fri, 3 Sep 2021 10:09:04 -0700	[thread overview]
Message-ID: <CA+ASDXM7GrbahVyneW=TwHi9Uu7sF+7GcC=U0866_m=GXnFmtQ@mail.gmail.com> (raw)
In-Reply-To: <20210903111023.GE4932@sirena.org.uk>

On Fri, Sep 3, 2021 at 4:11 AM Mark Brown <broonie@kernel.org> wrote:
> In terms of not understanding the issue here is that the patch didn't
> pass the smell test, it was your explanation that helped here not the
> pointing at a driver change that lacks obvious relevance.  I really
> don't know what the reader is supposed to infer about the change from
> the commit,

OK, I might see where you're coming from. Personally, I'd still like
to reference the commit in some way, because I've never used bypass
mode that I'm aware of, but the mentioned commit added a new case that
I do care about. I like documenting motivation, where reasonable --
but apparently I need to do a better job of that part.

> I don't think anyone came up with anything more tasteful to do with that
> hardware, like I say the hardware is itself very hacky.

OK. I guess I was specifically asking about this patch (and the new
usage of ->supply in commit 21e39809fd7c, to some extent). If the
usage of ->supply is the best we can/should do, then we can leave
21e39809fd7c alone. If you don't care to "fix" this log message, then
I can forget about $subject patch too.

Or, do you only want me to improve the commit message (drop the Fixes,
mention bypass mode, etc.) and resubmit?

Brian

  reply	other threads:[~2021-09-03 17:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 19:40 [PATCH] regulator: core: resolve supply voltage deferral silently Brian Norris
2021-09-01 15:08 ` Mark Brown
2021-09-01 20:06   ` Brian Norris
2021-09-02  4:09     ` Chen-Yu Tsai
2021-09-02 17:06     ` Mark Brown
2021-09-02 22:41       ` Brian Norris
2021-09-03 11:10         ` Mark Brown
2021-09-03 17:09           ` Brian Norris [this message]
2021-09-03 17:54             ` Mark Brown
2021-09-03 20:10               ` Brian Norris
2021-09-13 10:53 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ASDXM7GrbahVyneW=TwHi9Uu7sF+7GcC=U0866_m=GXnFmtQ@mail.gmail.com' \
    --to=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).