* [PATCH] media: staging: media: atomisp: fix return value
@ 2021-09-03 20:06 Alakesh Haloi
2021-09-06 7:32 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Alakesh Haloi @ 2021-09-03 20:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
Pavel Skripkin, linux-media, linux-staging, linux-kernel
This fixes following error seen during module build
error: control reaches end of non-void function [-Werror=return-type]
Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>
---
.../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..5d088d6fb01f 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
default:
return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
}
+ return status;
}
// Test flags and set structure.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: staging: media: atomisp: fix return value
2021-09-03 20:06 [PATCH] media: staging: media: atomisp: fix return value Alakesh Haloi
@ 2021-09-06 7:32 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-09-06 7:32 UTC (permalink / raw)
To: Alakesh Haloi
Cc: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
Pavel Skripkin, linux-media, linux-staging, linux-kernel
On Fri, Sep 03, 2021 at 08:06:58PM +0000, Alakesh Haloi wrote:
> This fixes following error seen during module build
> error: control reaches end of non-void function [-Werror=return-type]
>
> Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>
> ---
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..5d088d6fb01f 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
> default:
> return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
> }
> + return status;
You're working against a very old tree. This was fixed over a month
ago.
> }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-06 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 20:06 [PATCH] media: staging: media: atomisp: fix return value Alakesh Haloi
2021-09-06 7:32 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).