From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning
Date: Mon, 6 Sep 2021 12:56:05 +1000 [thread overview]
Message-ID: <20210906125605.658fe211@canb.auug.org.au> (raw)
In-Reply-To: <caf2449c-e86d-195d-3635-9be49159166a@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
Hi Jens,
On Thu, 2 Sep 2021 06:35:47 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/30/21 3:11 AM, Geert Uytterhoeven wrote:
> > If CONFIG_BLK_DEBUG_FS=n:
> >
> > block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
> > 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
> > | ^~~~~~~~~
> >
> > Fix this by moving dd_queued() just before the sole function that calls
> > it.
>
> Applied, thanks.
Can we get this to Linus ASAP as he has now made warnings fatal, so
this is causing lots of build failures.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-06 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 9:11 [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning Geert Uytterhoeven
2021-08-30 23:22 ` Bart Van Assche
2021-09-02 12:35 ` Jens Axboe
2021-09-06 2:56 ` Stephen Rothwell [this message]
2021-09-06 3:04 ` Jens Axboe
2021-09-06 6:56 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906125605.658fe211@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).