From: Bart Van Assche <bvanassche@acm.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning
Date: Mon, 30 Aug 2021 16:22:15 -0700 [thread overview]
Message-ID: <eaffaaba-ac90-62fe-7f7a-0e621f60cf73@acm.org> (raw)
In-Reply-To: <20210830091128.1854266-1-geert@linux-m68k.org>
On 8/30/21 2:11 AM, Geert Uytterhoeven wrote:
> If CONFIG_BLK_DEBUG_FS=n:
>
> block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
> 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
> | ^~~~~~~~~
>
> Fix this by moving dd_queued() just before the sole function that calls
> it.
>
> Fixes: 7b05bf771084ff78 ("Revert "block/mq-deadline: Prioritize high-priority requests"")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
The Fixes tag probably should be changed into the following:
Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2021-08-30 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 9:11 [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning Geert Uytterhoeven
2021-08-30 23:22 ` Bart Van Assche [this message]
2021-09-02 12:35 ` Jens Axboe
2021-09-06 2:56 ` Stephen Rothwell
2021-09-06 3:04 ` Jens Axboe
2021-09-06 6:56 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaffaaba-ac90-62fe-7f7a-0e621f60cf73@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).