* [PATCH] mailbox: bcm2835: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 7:40 Cai Huoqing
2021-09-07 8:29 ` nicolas saenz julienne
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-07 7:40 UTC (permalink / raw)
To: caihuoqing
Cc: Jassi Brar, Nicolas Saenz Julienne, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, linux-kernel,
linux-rpi-kernel, linux-arm-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/mailbox/bcm2835-mailbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
index 86b7ce3549c5..fbfd0202047c 100644
--- a/drivers/mailbox/bcm2835-mailbox.c
+++ b/drivers/mailbox/bcm2835-mailbox.c
@@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
int ret = 0;
- struct resource *iomem;
struct bcm2835_mbox *mbox;
mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
@@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
return -ENODEV;
}
- iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
+ mbox->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mbox->regs)) {
ret = PTR_ERR(mbox->regs);
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: bcm2835: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 7:40 [PATCH] mailbox: bcm2835: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-07 8:29 ` nicolas saenz julienne
0 siblings, 0 replies; 2+ messages in thread
From: nicolas saenz julienne @ 2021-09-07 8:29 UTC (permalink / raw)
To: Cai Huoqing
Cc: Jassi Brar, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, linux-kernel, linux-rpi-kernel,
linux-arm-kernel
On Tue, 2021-09-07 at 15:40 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Regards,
Nicolas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-07 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 7:40 [PATCH] mailbox: bcm2835: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 8:29 ` nicolas saenz julienne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).