* [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 8:51 ` Cai Huoqing
2021-09-07 12:28 ` Krzysztof Kozlowski
2021-09-13 16:15 ` Sylwester Nawrocki
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-07 8:51 UTC (permalink / raw)
To: caihuoqing
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/clk/samsung/clk-s5pv210-audss.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/samsung/clk-s5pv210-audss.c b/drivers/clk/samsung/clk-s5pv210-audss.c
index a7827a120695..b31c00ea331f 100644
--- a/drivers/clk/samsung/clk-s5pv210-audss.c
+++ b/drivers/clk/samsung/clk-s5pv210-audss.c
@@ -63,15 +63,13 @@ static struct syscore_ops s5pv210_audss_clk_syscore_ops = {
static int s5pv210_audss_clk_probe(struct platform_device *pdev)
{
int i, ret = 0;
- struct resource *res;
const char *mout_audss_p[2];
const char *mout_i2s_p[3];
const char *hclk_p;
struct clk_hw **clk_table;
struct clk *hclk, *pll_ref, *pll_in, *cdclk, *sclk_audio;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- reg_base = devm_ioremap_resource(&pdev->dev, res);
+ reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(reg_base))
return PTR_ERR(reg_base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 8:51 ` [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-07 12:28 ` Krzysztof Kozlowski
2021-09-13 16:15 ` Sylwester Nawrocki
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-07 12:28 UTC (permalink / raw)
To: Cai Huoqing
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 07/09/2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/clk/samsung/clk-s5pv210-audss.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 8:51 ` [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:28 ` Krzysztof Kozlowski
@ 2021-09-13 16:15 ` Sylwester Nawrocki
1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2021-09-13 16:15 UTC (permalink / raw)
To: Cai Huoqing
Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
On 07.09.2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
Thanks for the patch, I have applied it with summary line shortened to
"clk: samsung: s5pv210-audss: Make use of devm_platform_ioremap_resource()".
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-13 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210907085132eucas1p27810ad1f87867d1944b1c1b2c4b4abef@eucas1p2.samsung.com>
2021-09-07 8:51 ` [PATCH] clk: samsung: s5pv210-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:28 ` Krzysztof Kozlowski
2021-09-13 16:15 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).