* [PATCH] media: imx: set a media_device bus_info string
@ 2021-09-08 8:47 Martin Kepplinger
2021-09-08 22:37 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2021-09-08 8:47 UTC (permalink / raw)
To: slongerbeam, p.zabel, mchehab, laurent.pinchart
Cc: kernel, festevam, linux-imx, linux-media, linux-staging,
linux-arm-kernel, linux-kernel, Martin Kepplinger
some tools like v4l2-compliance let users select a media device based
on the bus_info string which can be quite convenient. Use a unique
string for that.
This also fixes the following v4l2-compliance warning:
warn: v4l2-test-media.cpp(52): empty bus_info
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
drivers/staging/media/imx/imx-media-dev-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
index d006e961d8f4..80b69a9a752c 100644
--- a/drivers/staging/media/imx/imx-media-dev-common.c
+++ b/drivers/staging/media/imx/imx-media-dev-common.c
@@ -367,6 +367,8 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev,
imxmd->v4l2_dev.notify = imx_media_notify;
strscpy(imxmd->v4l2_dev.name, "imx-media",
sizeof(imxmd->v4l2_dev.name));
+ snprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info),
+ "platform:%s", dev_name(imxmd->md.dev));
media_device_init(&imxmd->md);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: imx: set a media_device bus_info string
2021-09-08 8:47 [PATCH] media: imx: set a media_device bus_info string Martin Kepplinger
@ 2021-09-08 22:37 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2021-09-08 22:37 UTC (permalink / raw)
To: Martin Kepplinger
Cc: slongerbeam, p.zabel, mchehab, kernel, festevam, linux-imx,
linux-media, linux-staging, linux-arm-kernel, linux-kernel
Hi Martin,
Thank you for the patch.
On Wed, Sep 08, 2021 at 10:47:46AM +0200, Martin Kepplinger wrote:
> some tools like v4l2-compliance let users select a media device based
s/some/Some/
I'll fix then when applying the patch to my tree.
> on the bus_info string which can be quite convenient. Use a unique
> string for that.
>
> This also fixes the following v4l2-compliance warning:
> warn: v4l2-test-media.cpp(52): empty bus_info
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index d006e961d8f4..80b69a9a752c 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -367,6 +367,8 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev,
> imxmd->v4l2_dev.notify = imx_media_notify;
> strscpy(imxmd->v4l2_dev.name, "imx-media",
> sizeof(imxmd->v4l2_dev.name));
> + snprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info),
> + "platform:%s", dev_name(imxmd->md.dev));
>
> media_device_init(&imxmd->md);
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-08 22:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 8:47 [PATCH] media: imx: set a media_device bus_info string Martin Kepplinger
2021-09-08 22:37 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).