* [PATCH] cpufreq: vexpress: Drop unused variable
@ 2021-09-09 18:47 Guenter Roeck
2021-09-10 2:55 ` Kees Cook
2021-10-04 5:55 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-09-09 18:47 UTC (permalink / raw)
To: Viresh Kumar
Cc: Sudeep Holla, Rafael J . Wysocki, Liviu Dudau, Lorenzo Pieralisi,
linux-pm, linux-kernel, linux-arm-kernel, Guenter Roeck
arm:allmodconfig fails to build with the following error.
drivers/cpufreq/vexpress-spc-cpufreq.c:454:13: error:
unused variable 'cur_cluster'
Remove the unused variable.
Fixes: bb8c26d9387f ("cpufreq: vexpress: Set CPUFREQ_IS_COOLING_DEV flag")
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/cpufreq/vexpress-spc-cpufreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c
index 284b6bd040b1..d295f405c4bb 100644
--- a/drivers/cpufreq/vexpress-spc-cpufreq.c
+++ b/drivers/cpufreq/vexpress-spc-cpufreq.c
@@ -451,7 +451,6 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy)
static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy)
{
struct device *cpu_dev;
- int cur_cluster = cpu_to_cluster(policy->cpu);
cpu_dev = get_cpu_device(policy->cpu);
if (!cpu_dev) {
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: vexpress: Drop unused variable
2021-09-09 18:47 [PATCH] cpufreq: vexpress: Drop unused variable Guenter Roeck
@ 2021-09-10 2:55 ` Kees Cook
2021-10-04 5:55 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-09-10 2:55 UTC (permalink / raw)
To: Guenter Roeck
Cc: Viresh Kumar, Sudeep Holla, Rafael J . Wysocki, Liviu Dudau,
Lorenzo Pieralisi, linux-pm, linux-kernel, linux-arm-kernel
On Thu, Sep 09, 2021 at 11:47:14AM -0700, Guenter Roeck wrote:
> arm:allmodconfig fails to build with the following error.
>
> drivers/cpufreq/vexpress-spc-cpufreq.c:454:13: error:
> unused variable 'cur_cluster'
>
> Remove the unused variable.
>
> Fixes: bb8c26d9387f ("cpufreq: vexpress: Set CPUFREQ_IS_COOLING_DEV flag")
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
I hit this in build testing too.
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: vexpress: Drop unused variable
2021-09-09 18:47 [PATCH] cpufreq: vexpress: Drop unused variable Guenter Roeck
2021-09-10 2:55 ` Kees Cook
@ 2021-10-04 5:55 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-10-04 5:55 UTC (permalink / raw)
To: Guenter Roeck
Cc: Sudeep Holla, Rafael J . Wysocki, Liviu Dudau, Lorenzo Pieralisi,
linux-pm, linux-kernel, linux-arm-kernel
On 09-09-21, 11:47, Guenter Roeck wrote:
> arm:allmodconfig fails to build with the following error.
>
> drivers/cpufreq/vexpress-spc-cpufreq.c:454:13: error:
> unused variable 'cur_cluster'
>
> Remove the unused variable.
>
> Fixes: bb8c26d9387f ("cpufreq: vexpress: Set CPUFREQ_IS_COOLING_DEV flag")
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c
> index 284b6bd040b1..d295f405c4bb 100644
> --- a/drivers/cpufreq/vexpress-spc-cpufreq.c
> +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c
> @@ -451,7 +451,6 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy)
> static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy)
> {
> struct device *cpu_dev;
> - int cur_cluster = cpu_to_cluster(policy->cpu);
>
> cpu_dev = get_cpu_device(policy->cpu);
> if (!cpu_dev) {
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 18:47 [PATCH] cpufreq: vexpress: Drop unused variable Guenter Roeck
2021-09-10 2:55 ` Kees Cook
2021-10-04 5:55 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).