[PATCH] delayacct: optimize delayacct init

[PATCH] delayacct: optimize delayacct init

[cgel.zte]

From: Yang Yang <yang.yang29@zte.com.cn>

In delayacct_init(), first there is no need to assign delayacct_on to
delayacct_on in set_delayacct(). Second if delayacct_on is 0, there
is no need call delayacct_tsk_init().

Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
---
 kernel/delayacct.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/kernel/delayacct.c b/kernel/delayacct.c
index 51530d5b15a8..cbf80273be6d 100644
--- a/kernel/delayacct.c
+++ b/kernel/delayacct.c
@@ -39,8 +39,13 @@ __setup("delayacct", delayacct_setup_enable);
 void delayacct_init(void)
 {
 	delayacct_cache = KMEM_CACHE(task_delay_info, SLAB_PANIC|SLAB_ACCOUNT);
+
+	if (delayacct_on)
+		static_branch_enable(&delayacct_key);
+	else
+		return;
+
 	delayacct_tsk_init(&init_task);
-	set_delayacct(delayacct_on);
 }
 
 #ifdef CONFIG_PROC_SYSCTL
-- 
2.25.1

Re: [PATCH] delayacct: optimize delayacct init

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc1 next-20210914]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/delayacct-optimize-delayacct-init/20210911-154431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 926de8c4326c14fcf35f1de142019043597a4fac
config: i386-buildonly-randconfig-r002-20210914 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/13937a322a0ed37df1fc1db042d5128ec677af02
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review cgel-zte-gmail-com/delayacct-optimize-delayacct-init/20210911-154431
        git checkout 13937a322a0ed37df1fc1db042d5128ec677af02
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/delayacct.c:21:13: error: unused function 'set_delayacct' [-Werror,-Wunused-function]
   static void set_delayacct(bool enabled)
               ^
   1 error generated.


vim +/set_delayacct +21 kernel/delayacct.c

ca74e92b469827 Shailabh Nagar 2006-07-14  20  
0cd7c741f01de1 Peter Zijlstra 2021-05-10 @21  static void set_delayacct(bool enabled)
0cd7c741f01de1 Peter Zijlstra 2021-05-10  22  {
0cd7c741f01de1 Peter Zijlstra 2021-05-10  23  	if (enabled) {
0cd7c741f01de1 Peter Zijlstra 2021-05-10  24  		static_branch_enable(&delayacct_key);
0cd7c741f01de1 Peter Zijlstra 2021-05-10  25  		delayacct_on = 1;
0cd7c741f01de1 Peter Zijlstra 2021-05-10  26  	} else {
0cd7c741f01de1 Peter Zijlstra 2021-05-10  27  		delayacct_on = 0;
0cd7c741f01de1 Peter Zijlstra 2021-05-10  28  		static_branch_disable(&delayacct_key);
0cd7c741f01de1 Peter Zijlstra 2021-05-10  29  	}
0cd7c741f01de1 Peter Zijlstra 2021-05-10  30  }
0cd7c741f01de1 Peter Zijlstra 2021-05-10  31  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31590 bytes --]