* [PATCH 0/3] staging: r8188eu: clean up odm_types.h
@ 2021-09-13 19:20 Michael Straube
2021-09-13 19:20 ` [PATCH 1/3] staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE Michael Straube
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael Straube @ 2021-09-13 19:20 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
This series removes unused defines, an unused enum and an unnecessary
include from the header file odm_types.h.
Michael Straube (3):
staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE
staging: r8188eu: remove unused defines from odm_types.h
staging: r8188eu: remove unnecessary include from odm_types.h
drivers/staging/r8188eu/include/odm_types.h | 18 ------------------
1 file changed, 18 deletions(-)
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE
2021-09-13 19:20 [PATCH 0/3] staging: r8188eu: clean up odm_types.h Michael Straube
@ 2021-09-13 19:20 ` Michael Straube
2021-09-13 19:20 ` [PATCH 2/3] staging: r8188eu: remove unused defines from odm_types.h Michael Straube
2021-09-13 19:20 ` [PATCH 3/3] staging: r8188eu: remove unnecessary include " Michael Straube
2 siblings, 0 replies; 4+ messages in thread
From: Michael Straube @ 2021-09-13 19:20 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
The enum RT_SPINLOCK_TYPE is not used in the driver, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/include/odm_types.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/include/odm_types.h b/drivers/staging/r8188eu/include/odm_types.h
index 6f4a4bd37ec1..ecb2bef38351 100644
--- a/drivers/staging/r8188eu/include/odm_types.h
+++ b/drivers/staging/r8188eu/include/odm_types.h
@@ -21,10 +21,6 @@ enum HAL_STATUS {
HAL_STATUS_FAILURE,
};
-enum RT_SPINLOCK_TYPE {
- RT_TEMP = 1,
-};
-
#include "basic_types.h"
#define DEV_BUS_TYPE RT_USB_INTERFACE
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] staging: r8188eu: remove unused defines from odm_types.h
2021-09-13 19:20 [PATCH 0/3] staging: r8188eu: clean up odm_types.h Michael Straube
2021-09-13 19:20 ` [PATCH 1/3] staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE Michael Straube
@ 2021-09-13 19:20 ` Michael Straube
2021-09-13 19:20 ` [PATCH 3/3] staging: r8188eu: remove unnecessary include " Michael Straube
2 siblings, 0 replies; 4+ messages in thread
From: Michael Straube @ 2021-09-13 19:20 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
Remove unused defines from odm_types.h. This compiles without
introducing any new warnings.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/include/odm_types.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/r8188eu/include/odm_types.h b/drivers/staging/r8188eu/include/odm_types.h
index ecb2bef38351..b8a8465f08f9 100644
--- a/drivers/staging/r8188eu/include/odm_types.h
+++ b/drivers/staging/r8188eu/include/odm_types.h
@@ -12,10 +12,6 @@
#define ODM_CE 0x04 /* BIT(2) */
#define ODM_MP 0x08 /* BIT(3) */
-#define RT_PCI_INTERFACE 1
-#define RT_USB_INTERFACE 2
-#define RT_SDIO_INTERFACE 3
-
enum HAL_STATUS {
HAL_STATUS_SUCCESS,
HAL_STATUS_FAILURE,
@@ -23,8 +19,6 @@ enum HAL_STATUS {
#include "basic_types.h"
-#define DEV_BUS_TYPE RT_USB_INTERFACE
-
#define SET_TX_DESC_ANTSEL_A_88E(__ptxdesc, __value) \
le32p_replace_bits((__le32 *)(__ptxdesc + 8), __value, BIT(24))
#define SET_TX_DESC_ANTSEL_B_88E(__ptxdesc, __value) \
@@ -32,10 +26,4 @@ enum HAL_STATUS {
#define SET_TX_DESC_ANTSEL_C_88E(__ptxdesc, __value) \
le32p_replace_bits((__le32 *)(__ptxdesc + 28), __value, BIT(29))
-/* define useless flag to avoid compile warning */
-#define USE_WORKITEM 0
-#define FOR_BRAZIL_PRETEST 0
-#define BT_30_SUPPORT 0
-#define FPGA_TWO_MAC_VERIFICATION 0
-
#endif /* __ODM_TYPES_H__ */
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] staging: r8188eu: remove unnecessary include from odm_types.h
2021-09-13 19:20 [PATCH 0/3] staging: r8188eu: clean up odm_types.h Michael Straube
2021-09-13 19:20 ` [PATCH 1/3] staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE Michael Straube
2021-09-13 19:20 ` [PATCH 2/3] staging: r8188eu: remove unused defines from odm_types.h Michael Straube
@ 2021-09-13 19:20 ` Michael Straube
2 siblings, 0 replies; 4+ messages in thread
From: Michael Straube @ 2021-09-13 19:20 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
Including basic_types.h is not needed in odm_types.h.
Remove the include.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/include/odm_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/r8188eu/include/odm_types.h b/drivers/staging/r8188eu/include/odm_types.h
index b8a8465f08f9..7b6a3c392f2a 100644
--- a/drivers/staging/r8188eu/include/odm_types.h
+++ b/drivers/staging/r8188eu/include/odm_types.h
@@ -17,8 +17,6 @@ enum HAL_STATUS {
HAL_STATUS_FAILURE,
};
-#include "basic_types.h"
-
#define SET_TX_DESC_ANTSEL_A_88E(__ptxdesc, __value) \
le32p_replace_bits((__le32 *)(__ptxdesc + 8), __value, BIT(24))
#define SET_TX_DESC_ANTSEL_B_88E(__ptxdesc, __value) \
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-13 19:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 19:20 [PATCH 0/3] staging: r8188eu: clean up odm_types.h Michael Straube
2021-09-13 19:20 ` [PATCH 1/3] staging: r8188eu: remove unused enum RT_SPINLOCK_TYPE Michael Straube
2021-09-13 19:20 ` [PATCH 2/3] staging: r8188eu: remove unused defines from odm_types.h Michael Straube
2021-09-13 19:20 ` [PATCH 3/3] staging: r8188eu: remove unnecessary include " Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).