From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Saravana Kannan <saravanak@google.com>
Cc: John Stultz <john.stultz@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: [PATCH v1 5/5] driver core: Add fw_devlink.debug command line boolean parameter
Date: Mon, 13 Sep 2021 21:39:27 -0700 [thread overview]
Message-ID: <20210914043928.4066136-6-saravanak@google.com> (raw)
In-Reply-To: <20210914043928.4066136-1-saravanak@google.com>
When the parameter is set, it enables all the debug logs that would be
useful for debugging fw_devlink issues.
I'll add the documentation if we agree that we should add this param.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/base/base.h | 9 +++++++++
drivers/base/core.c | 34 ++++++++++++++++++++++++++--------
2 files changed, 35 insertions(+), 8 deletions(-)
diff --git a/drivers/base/base.h b/drivers/base/base.h
index 2882af26392a..e0744c08ccbe 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -191,6 +191,15 @@ extern void device_links_no_driver(struct device *dev);
extern bool device_links_busy(struct device *dev);
extern void device_links_unbind_consumers(struct device *dev);
extern void fw_devlink_drivers_done(void);
+extern bool fw_devlink_debug;
+
+#define fw_devlink_dbg(dev, fmt, ...) \
+do { \
+ if (fw_devlink_debug) \
+ dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__); \
+ else \
+ dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__); \
+} while (0)
/* device pm support */
void device_pm_move_to_tail(struct device *dev);
diff --git a/drivers/base/core.c b/drivers/base/core.c
index b10c425f4b89..d3be785820ca 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -95,8 +95,12 @@ int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup)
list_add(&link->s_hook, &sup->consumers);
list_add(&link->c_hook, &con->suppliers);
- pr_debug("%pfwP Linked as a fwnode consumer to %pfwP\n",
- con, sup);
+ if (fw_devlink_debug)
+ pr_info("%pfwP Linked as a fwnode consumer to %pfwP\n",
+ con, sup);
+ else
+ pr_debug("%pfwP Linked as a fwnode consumer to %pfwP\n",
+ con, sup);
out:
mutex_unlock(&fwnode_link_lock);
@@ -111,8 +115,12 @@ int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup)
*/
static void __fwnode_link_del(struct fwnode_link *link)
{
- pr_debug("%pfwP Dropping the fwnode link to %pfwP\n",
- link->consumer, link->supplier);
+ if (fw_devlink_debug)
+ pr_info("%pfwP Dropping the fwnode link to %pfwP\n",
+ link->consumer, link->supplier);
+ else
+ pr_debug("%pfwP Dropping the fwnode link to %pfwP\n",
+ link->consumer, link->supplier);
list_del(&link->s_hook);
list_del(&link->c_hook);
kfree(link);
@@ -852,7 +860,7 @@ struct device_link *device_link_add(struct device *consumer,
list_add_tail_rcu(&link->c_node, &consumer->links.suppliers);
if (flags & DL_FLAG_SYNC_STATE_ONLY) {
- dev_dbg(consumer,
+ fw_devlink_dbg(consumer,
"Linked as a sync state only consumer to %s\n",
dev_name(supplier));
goto out;
@@ -868,7 +876,8 @@ struct device_link *device_link_add(struct device *consumer,
*/
device_reorder_to_tail(consumer, NULL);
- dev_dbg(consumer, "Linked as a consumer to %s\n", dev_name(supplier));
+ fw_devlink_dbg(consumer, "Linked as a consumer to %s\n",
+ dev_name(supplier));
out:
device_pm_unlock();
@@ -1021,7 +1030,8 @@ int device_links_check_suppliers(struct device *dev)
sup_fw = list_first_entry(&dev->fwnode->suppliers,
struct fwnode_link,
c_hook)->supplier;
- dev_dbg(dev, "probe deferral - wait for supplier %pfwP\n",
+ fw_devlink_dbg(dev,
+ "probe deferral - wait for supplier %pfwP\n",
sup_fw);
dev_set_def_probe_reason(dev,
"wait for supplier %pfwP\n", sup_fw);
@@ -1039,7 +1049,8 @@ int device_links_check_suppliers(struct device *dev)
if (link->status != DL_STATE_AVAILABLE &&
!(link->flags & DL_FLAG_SYNC_STATE_ONLY)) {
device_links_missing_supplier(dev);
- dev_dbg(dev, "probe deferral - supplier %s not ready\n",
+ fw_devlink_dbg(dev,
+ "probe deferral - supplier %s not ready\n",
dev_name(link->supplier));
dev_set_def_probe_reason(dev,
"supplier %s not ready\n",
@@ -1616,6 +1627,13 @@ static int __init fw_devlink_strict_setup(char *arg)
}
early_param("fw_devlink.strict", fw_devlink_strict_setup);
+bool fw_devlink_debug;
+static int __init fw_devlink_debug_setup(char *arg)
+{
+ return strtobool(arg, &fw_devlink_debug);
+}
+early_param("fw_devlink.debug", fw_devlink_debug_setup);
+
u32 fw_devlink_get_flags(void)
{
return fw_devlink_flags;
--
2.33.0.309.g3052b89438-goog
next prev parent reply other threads:[~2021-09-14 4:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 4:39 [PATCH v1 0/5] fw_devlink improvements Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 1/5] driver core: fw_devlink: Improve handling of cyclic dependencies Saravana Kannan
2021-09-14 6:16 ` Marek Szyprowski
2021-09-14 8:01 ` Saravana Kannan
2021-09-14 12:35 ` Rob Herring
2021-09-14 16:23 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 2/5] driver core: Set deferred probe reason when deferred by driver core Saravana Kannan
2021-09-14 7:01 ` Geert Uytterhoeven
2021-09-14 7:58 ` Saravana Kannan
2021-09-15 5:41 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 3/5] driver core: Create __fwnode_link_del() helper function Saravana Kannan
2021-09-14 7:04 ` Geert Uytterhoeven
2021-09-14 7:46 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 4/5] driver core: Add debug logs when fwnode links are added/deleted Saravana Kannan
2021-09-14 7:09 ` Geert Uytterhoeven
2021-09-14 4:39 ` Saravana Kannan [this message]
2021-09-14 15:10 ` [PATCH v1 5/5] driver core: Add fw_devlink.debug command line boolean parameter Andrew Lunn
2021-09-14 16:27 ` Saravana Kannan
2021-09-14 16:43 ` Andrew Lunn
2021-09-14 16:52 ` Rob Herring
2021-09-14 17:31 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914043928.4066136-6-saravanak@google.com \
--to=saravanak@google.com \
--cc=andrew@lunn.ch \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).