From: Saravana Kannan <saravanak@google.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Vladimir Oltean <olteanv@gmail.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] driver core: Add fw_devlink.debug command line boolean parameter
Date: Tue, 14 Sep 2021 09:27:48 -0700 [thread overview]
Message-ID: <CAGETcx-B+yE8X2rn4GdzAikVO-swXb9a5-CxOG_HSuiQoHQZcw@mail.gmail.com> (raw)
In-Reply-To: <YUC7c9BNuHPOEg4g@lunn.ch>
On Tue, Sep 14, 2021 at 8:10 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Sep 13, 2021 at 09:39:27PM -0700, Saravana Kannan wrote:
> > When the parameter is set, it enables all the debug logs that would be
> > useful for debugging fw_devlink issues.
> >
> > I'll add the documentation if we agree that we should add this param.
>
> https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html
>
> It is better to make use of existing infrastructure, maybe with
> extensions if needed.
I did think of this, but the problem is that dynamic debug logs can
get compiled out (when DYNAMIC_DEBUG isn't set). I think debugging of
fw_devlink needs to be possible without having to recompile the
kernel. So in a sense similar to how initcall_debug works today.
-Saravana
next prev parent reply other threads:[~2021-09-14 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 4:39 [PATCH v1 0/5] fw_devlink improvements Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 1/5] driver core: fw_devlink: Improve handling of cyclic dependencies Saravana Kannan
2021-09-14 6:16 ` Marek Szyprowski
2021-09-14 8:01 ` Saravana Kannan
2021-09-14 12:35 ` Rob Herring
2021-09-14 16:23 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 2/5] driver core: Set deferred probe reason when deferred by driver core Saravana Kannan
2021-09-14 7:01 ` Geert Uytterhoeven
2021-09-14 7:58 ` Saravana Kannan
2021-09-15 5:41 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 3/5] driver core: Create __fwnode_link_del() helper function Saravana Kannan
2021-09-14 7:04 ` Geert Uytterhoeven
2021-09-14 7:46 ` Saravana Kannan
2021-09-14 4:39 ` [PATCH v1 4/5] driver core: Add debug logs when fwnode links are added/deleted Saravana Kannan
2021-09-14 7:09 ` Geert Uytterhoeven
2021-09-14 4:39 ` [PATCH v1 5/5] driver core: Add fw_devlink.debug command line boolean parameter Saravana Kannan
2021-09-14 15:10 ` Andrew Lunn
2021-09-14 16:27 ` Saravana Kannan [this message]
2021-09-14 16:43 ` Andrew Lunn
2021-09-14 16:52 ` Rob Herring
2021-09-14 17:31 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGETcx-B+yE8X2rn4GdzAikVO-swXb9a5-CxOG_HSuiQoHQZcw@mail.gmail.com \
--to=saravanak@google.com \
--cc=andrew@lunn.ch \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).