* [PATCH] reset: brcmstb-rescal: fix incorrect polarity of status bit
@ 2021-09-14 22:11 Florian Fainelli
2021-10-05 9:54 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2021-09-14 22:11 UTC (permalink / raw)
To: linux-kernel
Cc: Jim Quinlan, Florian Fainelli, Philipp Zabel,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
From: Jim Quinlan <jim2101024@gmail.com>
The readl_poll_timeout() should complete when the status bit
is a 1, not 0.
Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller")
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/reset/reset-brcmstb-rescal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/reset-brcmstb-rescal.c b/drivers/reset/reset-brcmstb-rescal.c
index b6f074d6a65f..433fa0c40e47 100644
--- a/drivers/reset/reset-brcmstb-rescal.c
+++ b/drivers/reset/reset-brcmstb-rescal.c
@@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
}
ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
- !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
+ (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
if (ret) {
dev_err(data->dev, "time out on SATA/PCIe rescal\n");
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: brcmstb-rescal: fix incorrect polarity of status bit
2021-09-14 22:11 [PATCH] reset: brcmstb-rescal: fix incorrect polarity of status bit Florian Fainelli
@ 2021-10-05 9:54 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2021-10-05 9:54 UTC (permalink / raw)
To: Florian Fainelli, linux-kernel
Cc: Jim Quinlan, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
On Tue, 2021-09-14 at 15:11 -0700, Florian Fainelli wrote:
> From: Jim Quinlan <jim2101024@gmail.com>
>
> The readl_poll_timeout() should complete when the status bit
> is a 1, not 0.
>
> Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller")
> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/reset/reset-brcmstb-rescal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-brcmstb-rescal.c b/drivers/reset/reset-brcmstb-rescal.c
> index b6f074d6a65f..433fa0c40e47 100644
> --- a/drivers/reset/reset-brcmstb-rescal.c
> +++ b/drivers/reset/reset-brcmstb-rescal.c
> @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
> }
>
> ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
> - !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
> + (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
> if (ret) {
> dev_err(data->dev, "time out on SATA/PCIe rescal\n");
> return ret;
Thank you, applied to reset/fixes.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 22:11 [PATCH] reset: brcmstb-rescal: fix incorrect polarity of status bit Florian Fainelli
2021-10-05 9:54 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).