* [PATCH v4 1/2] virt: acrn: Introduce interfaces for MMIO device passthrough
2021-09-14 6:26 [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Fei Li
@ 2021-09-14 6:26 ` Fei Li
2021-09-14 6:26 ` [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying Fei Li
2021-09-14 6:59 ` [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Greg KH
2 siblings, 0 replies; 7+ messages in thread
From: Fei Li @ 2021-09-14 6:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, yu1.wang, shuox.liu, fei1.li
From: Shuo Liu <shuo.a.liu@intel.com>
MMIO device passthrough enables an OS in a virtual machine to directly
access a MMIO device in the host. It promises almost the native
performance, which is required in performance-critical scenarios of
ACRN.
HSM provides the following ioctls:
- Assign - ACRN_IOCTL_ASSIGN_MMIODEV
Pass data struct acrn_mmiodev from userspace to the hypervisor, and
inform the hypervisor to assign a MMIO device to a User VM.
- De-assign - ACRN_IOCTL_DEASSIGN_PCIDEV
Pass data struct acrn_mmiodev from userspace to the hypervisor, and
inform the hypervisor to de-assign a MMIO device from a User VM.
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
Signed-off-by: Fei Li <fei1.li@intel.com>
---
drivers/virt/acrn/hsm.c | 25 +++++++++++++++++++++++++
drivers/virt/acrn/hypercall.h | 26 ++++++++++++++++++++++++++
include/uapi/linux/acrn.h | 28 ++++++++++++++++++++++++++++
3 files changed, 79 insertions(+)
diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
index 130e12b8652a..f567ca59d7c2 100644
--- a/drivers/virt/acrn/hsm.c
+++ b/drivers/virt/acrn/hsm.c
@@ -114,6 +114,7 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
struct acrn_ptdev_irq *irq_info;
struct acrn_ioeventfd ioeventfd;
struct acrn_vm_memmap memmap;
+ struct acrn_mmiodev *mmiodev;
struct acrn_msi_entry *msi;
struct acrn_pcidev *pcidev;
struct acrn_irqfd irqfd;
@@ -217,6 +218,30 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
ret = acrn_vm_memseg_unmap(vm, &memmap);
break;
+ case ACRN_IOCTL_ASSIGN_MMIODEV:
+ mmiodev = memdup_user((void __user *)ioctl_param,
+ sizeof(struct acrn_mmiodev));
+ if (IS_ERR(mmiodev))
+ return PTR_ERR(mmiodev);
+
+ ret = hcall_assign_mmiodev(vm->vmid, virt_to_phys(mmiodev));
+ if (ret < 0)
+ dev_dbg(acrn_dev.this_device,
+ "Failed to assign MMIO device!\n");
+ kfree(mmiodev);
+ break;
+ case ACRN_IOCTL_DEASSIGN_MMIODEV:
+ mmiodev = memdup_user((void __user *)ioctl_param,
+ sizeof(struct acrn_mmiodev));
+ if (IS_ERR(mmiodev))
+ return PTR_ERR(mmiodev);
+
+ ret = hcall_deassign_mmiodev(vm->vmid, virt_to_phys(mmiodev));
+ if (ret < 0)
+ dev_dbg(acrn_dev.this_device,
+ "Failed to deassign MMIO device!\n");
+ kfree(mmiodev);
+ break;
case ACRN_IOCTL_ASSIGN_PCIDEV:
pcidev = memdup_user((void __user *)ioctl_param,
sizeof(struct acrn_pcidev));
diff --git a/drivers/virt/acrn/hypercall.h b/drivers/virt/acrn/hypercall.h
index 0cfad05bd1a9..f0c78e52cebb 100644
--- a/drivers/virt/acrn/hypercall.h
+++ b/drivers/virt/acrn/hypercall.h
@@ -41,6 +41,8 @@
#define HC_RESET_PTDEV_INTR _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x04)
#define HC_ASSIGN_PCIDEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x05)
#define HC_DEASSIGN_PCIDEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x06)
+#define HC_ASSIGN_MMIODEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x07)
+#define HC_DEASSIGN_MMIODEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x08)
#define HC_ID_PM_BASE 0x80UL
#define HC_PM_GET_CPU_STATE _HC_ID(HC_ID, HC_ID_PM_BASE + 0x00)
@@ -194,6 +196,30 @@ static inline long hcall_set_memory_regions(u64 regions_pa)
return acrn_hypercall1(HC_VM_SET_MEMORY_REGIONS, regions_pa);
}
+/**
+ * hcall_assign_mmiodev() - Assign a MMIO device to a User VM
+ * @vmid: User VM ID
+ * @addr: Service VM GPA of the &struct acrn_mmiodev
+ *
+ * Return: 0 on success, <0 on failure
+ */
+static inline long hcall_assign_mmiodev(u64 vmid, u64 addr)
+{
+ return acrn_hypercall2(HC_ASSIGN_MMIODEV, vmid, addr);
+}
+
+/**
+ * hcall_deassign_mmiodev() - De-assign a PCI device from a User VM
+ * @vmid: User VM ID
+ * @addr: Service VM GPA of the &struct acrn_mmiodev
+ *
+ * Return: 0 on success, <0 on failure
+ */
+static inline long hcall_deassign_mmiodev(u64 vmid, u64 addr)
+{
+ return acrn_hypercall2(HC_DEASSIGN_MMIODEV, vmid, addr);
+}
+
/**
* hcall_assign_pcidev() - Assign a PCI device to a User VM
* @vmid: User VM ID
diff --git a/include/uapi/linux/acrn.h b/include/uapi/linux/acrn.h
index 353b2a2e4536..470036d6b1ac 100644
--- a/include/uapi/linux/acrn.h
+++ b/include/uapi/linux/acrn.h
@@ -396,6 +396,7 @@ struct acrn_ptdev_irq {
/* Type of PCI device assignment */
#define ACRN_PTDEV_QUIRK_ASSIGN (1U << 0)
+#define ACRN_MMIODEV_RES_NUM 3
#define ACRN_PCI_NUM_BARS 6
/**
* struct acrn_pcidev - Info for assigning or de-assigning a PCI device
@@ -417,6 +418,29 @@ struct acrn_pcidev {
__u32 bar[ACRN_PCI_NUM_BARS];
};
+/**
+ * struct acrn_mmiodev - Info for assigning or de-assigning a MMIO device
+ * @name: Name of the MMIO device.
+ * @res[].user_vm_pa: Physical address of User VM of the MMIO region
+ * for the MMIO device.
+ * @res[].service_vm_pa: Physical address of Service VM of the MMIO
+ * region for the MMIO device.
+ * @res[].size: Size of the MMIO region for the MMIO device.
+ * @res[].mem_type: Memory type of the MMIO region for the MMIO
+ * device.
+ *
+ * This structure will be passed to hypervisor directly.
+ */
+struct acrn_mmiodev {
+ __u8 name[8];
+ struct {
+ __u64 user_vm_pa;
+ __u64 service_vm_pa;
+ __u64 size;
+ __u64 mem_type;
+ } res[ACRN_MMIODEV_RES_NUM];
+};
+
/**
* struct acrn_msi_entry - Info for injecting a MSI interrupt to a VM
* @msi_addr: MSI addr[19:12] with dest vCPU ID
@@ -568,6 +592,10 @@ struct acrn_irqfd {
_IOW(ACRN_IOCTL_TYPE, 0x55, struct acrn_pcidev)
#define ACRN_IOCTL_DEASSIGN_PCIDEV \
_IOW(ACRN_IOCTL_TYPE, 0x56, struct acrn_pcidev)
+#define ACRN_IOCTL_ASSIGN_MMIODEV \
+ _IOW(ACRN_IOCTL_TYPE, 0x57, struct acrn_mmiodev)
+#define ACRN_IOCTL_DEASSIGN_MMIODEV \
+ _IOW(ACRN_IOCTL_TYPE, 0x58, struct acrn_mmiodev)
#define ACRN_IOCTL_PM_GET_CPU_STATE \
_IOWR(ACRN_IOCTL_TYPE, 0x60, __u64)
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying
2021-09-14 6:26 [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Fei Li
2021-09-14 6:26 ` [PATCH v4 1/2] virt: acrn: Introduce interfaces for MMIO device passthrough Fei Li
@ 2021-09-14 6:26 ` Fei Li
2021-09-14 7:00 ` Greg KH
2021-09-14 6:59 ` [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Greg KH
2 siblings, 1 reply; 7+ messages in thread
From: Fei Li @ 2021-09-14 6:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, yu1.wang, shuox.liu, fei1.li
From: Shuo Liu <shuo.a.liu@intel.com>
The ACRN hypervisor can emulate a virtual device within hypervisor for a
Guest VM. The emulated virtual device can work without the ACRN
userspace after creation. The hypervisor do the emulation of that device.
To support the virtual device creating/destroying, HSM provides the
following ioctls:
- ACRN_IOCTL_CREATE_VDEV
Pass data struct acrn_vdev from userspace to the hypervisor, and inform
the hypervisor to create a virtual device for a User VM.
- ACRN_IOCTL_DESTROY_VDEV
Pass data struct acrn_vdev from userspace to the hypervisor, and inform
the hypervisor to destroy a virtual device of a User VM.
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
Signed-off-by: Fei Li <fei1.li@intel.com>
---
drivers/virt/acrn/hsm.c | 24 ++++++++++++++++++++
drivers/virt/acrn/hypercall.h | 26 ++++++++++++++++++++++
include/uapi/linux/acrn.h | 42 +++++++++++++++++++++++++++++++++++
3 files changed, 92 insertions(+)
diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
index f567ca59d7c2..5419794fccf1 100644
--- a/drivers/virt/acrn/hsm.c
+++ b/drivers/virt/acrn/hsm.c
@@ -118,6 +118,7 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
struct acrn_msi_entry *msi;
struct acrn_pcidev *pcidev;
struct acrn_irqfd irqfd;
+ struct acrn_vdev *vdev;
struct page *page;
u64 cstate_cmd;
int i, ret = 0;
@@ -266,6 +267,29 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
"Failed to deassign pci device!\n");
kfree(pcidev);
break;
+ case ACRN_IOCTL_CREATE_VDEV:
+ vdev = memdup_user((void __user *)ioctl_param,
+ sizeof(struct acrn_vdev));
+ if (IS_ERR(vdev))
+ return PTR_ERR(vdev);
+
+ ret = hcall_create_vdev(vm->vmid, virt_to_phys(vdev));
+ if (ret < 0)
+ dev_dbg(acrn_dev.this_device,
+ "Failed to create virtual device!\n");
+ kfree(vdev);
+ break;
+ case ACRN_IOCTL_DESTROY_VDEV:
+ vdev = memdup_user((void __user *)ioctl_param,
+ sizeof(struct acrn_vdev));
+ if (IS_ERR(vdev))
+ return PTR_ERR(vdev);
+ ret = hcall_destroy_vdev(vm->vmid, virt_to_phys(vdev));
+ if (ret < 0)
+ dev_dbg(acrn_dev.this_device,
+ "Failed to destroy virtual device!\n");
+ kfree(vdev);
+ break;
case ACRN_IOCTL_SET_PTDEV_INTR:
irq_info = memdup_user((void __user *)ioctl_param,
sizeof(struct acrn_ptdev_irq));
diff --git a/drivers/virt/acrn/hypercall.h b/drivers/virt/acrn/hypercall.h
index f0c78e52cebb..71d300821a18 100644
--- a/drivers/virt/acrn/hypercall.h
+++ b/drivers/virt/acrn/hypercall.h
@@ -43,6 +43,8 @@
#define HC_DEASSIGN_PCIDEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x06)
#define HC_ASSIGN_MMIODEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x07)
#define HC_DEASSIGN_MMIODEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x08)
+#define HC_CREATE_VDEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x09)
+#define HC_DESTROY_VDEV _HC_ID(HC_ID, HC_ID_PCI_BASE + 0x0A)
#define HC_ID_PM_BASE 0x80UL
#define HC_PM_GET_CPU_STATE _HC_ID(HC_ID, HC_ID_PM_BASE + 0x00)
@@ -196,6 +198,30 @@ static inline long hcall_set_memory_regions(u64 regions_pa)
return acrn_hypercall1(HC_VM_SET_MEMORY_REGIONS, regions_pa);
}
+/**
+ * hcall_create_vdev() - Create a virtual device for a User VM
+ * @vmid: User VM ID
+ * @addr: Service VM GPA of the &struct acrn_vdev
+ *
+ * Return: 0 on success, <0 on failure
+ */
+static inline long hcall_create_vdev(u64 vmid, u64 addr)
+{
+ return acrn_hypercall2(HC_CREATE_VDEV, vmid, addr);
+}
+
+/**
+ * hcall_destroy_vdev() - Destroy a virtual device of a User VM
+ * @vmid: User VM ID
+ * @addr: Service VM GPA of the &struct acrn_vdev
+ *
+ * Return: 0 on success, <0 on failure
+ */
+static inline long hcall_destroy_vdev(u64 vmid, u64 addr)
+{
+ return acrn_hypercall2(HC_DESTROY_VDEV, vmid, addr);
+}
+
/**
* hcall_assign_mmiodev() - Assign a MMIO device to a User VM
* @vmid: User VM ID
diff --git a/include/uapi/linux/acrn.h b/include/uapi/linux/acrn.h
index 470036d6b1ac..1408d1063339 100644
--- a/include/uapi/linux/acrn.h
+++ b/include/uapi/linux/acrn.h
@@ -441,6 +441,44 @@ struct acrn_mmiodev {
} res[ACRN_MMIODEV_RES_NUM];
};
+/**
+ * struct acrn_vdev - Info for creating or destroying a virtual device
+ * @id: Union of identifier of the virtual device
+ * @id.value: Raw data of the identifier
+ * @id.fields.vendor: Vendor id of the virtual PCI device
+ * @id.fields.device: Device id of the virtual PCI device
+ * @id.fields.legacy_id: ID of the virtual device if not a PCI device
+ * @slot: Virtual Bus/Device/Function of the virtual
+ * device
+ * @io_base: IO resource base address of the virtual device
+ * @io_size: IO resource size of the virtual device
+ * @args: Arguments for the virtual device creation
+ *
+ * The created virtual device can be a PCI device or a legacy device (e.g.
+ * a virtual UART controller) and it is emulated by the hypervisor. This
+ * structure will be passed to hypervisor directly.
+ */
+struct acrn_vdev {
+ /*
+ * the identifier of the device, the low 32 bits represent the vendor
+ * id and device id of PCI device and the high 32 bits represent the
+ * device number of the legacy device
+ */
+ union {
+ __u64 value;
+ struct {
+ __u16 vendor;
+ __u16 device;
+ __u32 legacy_id;
+ } fields;
+ } id;
+
+ __u64 slot;
+ __u32 io_addr[ACRN_PCI_NUM_BARS];
+ __u32 io_size[ACRN_PCI_NUM_BARS];
+ __u8 args[128];
+};
+
/**
* struct acrn_msi_entry - Info for injecting a MSI interrupt to a VM
* @msi_addr: MSI addr[19:12] with dest vCPU ID
@@ -596,6 +634,10 @@ struct acrn_irqfd {
_IOW(ACRN_IOCTL_TYPE, 0x57, struct acrn_mmiodev)
#define ACRN_IOCTL_DEASSIGN_MMIODEV \
_IOW(ACRN_IOCTL_TYPE, 0x58, struct acrn_mmiodev)
+#define ACRN_IOCTL_CREATE_VDEV \
+ _IOW(ACRN_IOCTL_TYPE, 0x59, struct acrn_vdev)
+#define ACRN_IOCTL_DESTROY_VDEV \
+ _IOW(ACRN_IOCTL_TYPE, 0x5A, struct acrn_vdev)
#define ACRN_IOCTL_PM_GET_CPU_STATE \
_IOWR(ACRN_IOCTL_TYPE, 0x60, __u64)
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying
2021-09-14 6:26 ` [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying Fei Li
@ 2021-09-14 7:00 ` Greg KH
2021-09-15 1:35 ` Li Fei1
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-09-14 7:00 UTC (permalink / raw)
To: Fei Li; +Cc: linux-kernel, yu1.wang, shuox.liu
On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote:
> +struct acrn_vdev {
> + /*
> + * the identifier of the device, the low 32 bits represent the vendor
> + * id and device id of PCI device and the high 32 bits represent the
> + * device number of the legacy device
> + */
> + union {
> + __u64 value;
> + struct {
> + __u16 vendor;
> + __u16 device;
> + __u32 legacy_id;
What is the endian of these fields?
Please always specify them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying
2021-09-14 7:00 ` Greg KH
@ 2021-09-15 1:35 ` Li Fei1
0 siblings, 0 replies; 7+ messages in thread
From: Li Fei1 @ 2021-09-15 1:35 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, yu1.wang, shuox.liu, fei1.li
On Tue, Sep 14, 2021 at 09:00:48AM +0200, Greg KH wrote:
> On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote:
> > +struct acrn_vdev {
> > + /*
> > + * the identifier of the device, the low 32 bits represent the vendor
> > + * id and device id of PCI device and the high 32 bits represent the
> > + * device number of the legacy device
> > + */
> > + union {
> > + __u64 value;
> > + struct {
> > + __u16 vendor;
> > + __u16 device;
> > + __u32 legacy_id;
>
> What is the endian of these fields?
"Big-endian" or "Little-endian" ? If yes, they're Little-endian.
>
> Please always specify them.
Sure.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver
2021-09-14 6:26 [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Fei Li
2021-09-14 6:26 ` [PATCH v4 1/2] virt: acrn: Introduce interfaces for MMIO device passthrough Fei Li
2021-09-14 6:26 ` [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying Fei Li
@ 2021-09-14 6:59 ` Greg KH
2021-09-15 1:44 ` Li Fei1
2 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-09-14 6:59 UTC (permalink / raw)
To: Fei Li; +Cc: linux-kernel, yu1.wang, shuox.liu
On Tue, Sep 14, 2021 at 02:26:25PM +0800, Fei Li wrote:
> Add some new interfaces for ACRN hypervisor HSM driver:
> - MMIO device passthrough
> - virtual device creating/destroying
> - platform information fetching from the hypervisor
>
> ChangeLog:
> v4:
> - remove "RFC" from Subject field.
>
> v3:
> - remove "platform information fetching from the hypervisor". What platform
> information needs to be fetched has not been finally decided. Will send tis
> patch out once that has been decided.
> - add comments where is the userspace code that uses this new api:
> - MMIO device passthrough
> (a) assign a MMIO device to a User VM
> https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L562
> (b) de-assign a MMIO device from a User VM
> https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L568
> - virtual device creating/destroying
> (a) create a virtual device for a User VM
> https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L606
> (b) destroy a virtual device of a User VM
> https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L612
Can you put these comments in the changelog text? Stuff in the 0/X
email never shows up in the changelog at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver
2021-09-14 6:59 ` [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Greg KH
@ 2021-09-15 1:44 ` Li Fei1
0 siblings, 0 replies; 7+ messages in thread
From: Li Fei1 @ 2021-09-15 1:44 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, yu1.wang, shuox.liu, fei1.li
On Tue, Sep 14, 2021 at 08:59:58AM +0200, Greg KH wrote:
> On Tue, Sep 14, 2021 at 02:26:25PM +0800, Fei Li wrote:
> > Add some new interfaces for ACRN hypervisor HSM driver:
> > - MMIO device passthrough
> > - virtual device creating/destroying
> > - platform information fetching from the hypervisor
> >
> > ChangeLog:
> > v4:
> > - remove "RFC" from Subject field.
> >
> > v3:
> > - remove "platform information fetching from the hypervisor". What platform
> > information needs to be fetched has not been finally decided. Will send tis
> > patch out once that has been decided.
> > - add comments where is the userspace code that uses this new api:
> > - MMIO device passthrough
> > (a) assign a MMIO device to a User VM
> > https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L562
> > (b) de-assign a MMIO device from a User VM
> > https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L568
> > - virtual device creating/destroying
> > (a) create a virtual device for a User VM
> > https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L606
> > (b) destroy a virtual device of a User VM
> > https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L612
>
> Can you put these comments in the changelog text? Stuff in the 0/X
> email never shows up in the changelog at all.
Hi Greg
What's the "changelog text" mean ? Would you please tell how could I do this ?
I see peoples always describe what does their patches change in the cover letter
(the 0/X email).
thanks.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread