* [PATCH] drm/bochs: add Bochs PCI ID for Simics model
@ 2021-09-10 1:06 H. Peter Anvin (Intel)
2021-09-15 6:29 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin (Intel) @ 2021-09-10 1:06 UTC (permalink / raw)
To: Gerd Hoffmann, David Airlie, Daniel Vetter
Cc: virtualization, dri-devel, linux-kernel, H. Peter Anvin (Intel)
Current (and older) Simics models for the Bochs VGA used the wrong PCI
vendor ID (0x4321 instead of 0x1234). Although this can hopefully be
fixed in the future, it is a problem for users of the current version,
not the least because to update the device ID the BIOS has to be
rebuilt in order to see BIOS output.
Add support for the 4321:1111 device number in addition to the
1234:1111 one.
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
---
drivers/gpu/drm/tiny/bochs.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 73415fa9ae0f..2ce3bd903b70 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -63,6 +63,7 @@ MODULE_PARM_DESC(defy, "default y resolution");
enum bochs_types {
BOCHS_QEMU_STDVGA,
+ BOCHS_SIMICS,
BOCHS_UNKNOWN,
};
@@ -695,6 +696,13 @@ static const struct pci_device_id bochs_pci_tbl[] = {
.subdevice = PCI_ANY_ID,
.driver_data = BOCHS_UNKNOWN,
},
+ {
+ .vendor = 0x4321,
+ .device = 0x1111,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = BOCHS_SIMICS,
+ },
{ /* end of list */ }
};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bochs: add Bochs PCI ID for Simics model
2021-09-10 1:06 [PATCH] drm/bochs: add Bochs PCI ID for Simics model H. Peter Anvin (Intel)
@ 2021-09-15 6:29 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2021-09-15 6:29 UTC (permalink / raw)
To: H. Peter Anvin (Intel)
Cc: David Airlie, Daniel Vetter, virtualization, dri-devel, linux-kernel
On Thu, Sep 09, 2021 at 06:06:55PM -0700, H. Peter Anvin (Intel) wrote:
> Current (and older) Simics models for the Bochs VGA used the wrong PCI
> vendor ID (0x4321 instead of 0x1234). Although this can hopefully be
> fixed in the future, it is a problem for users of the current version,
> not the least because to update the device ID the BIOS has to be
> rebuilt in order to see BIOS output.
>
> Add support for the 4321:1111 device number in addition to the
> 1234:1111 one.
>
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Pusged to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drm/bochs: add Bochs PCI ID for Simics model
2021-09-10 19:59 ` [PATCH v3 0/2] x86/asm: avoid register pressure from the init " H. Peter Anvin (Intel)
@ 2021-09-10 19:59 ` H. Peter Anvin (Intel)
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin (Intel) @ 2021-09-10 19:59 UTC (permalink / raw)
To: Borislav Petkov, Ingo Molnar, Thomas Gleixner, Andy Lutomirski
Cc: x86 mailing list, Linux Kernel Mailing List, H. Peter Anvin (Intel)
Current (and older) Simics models for the Bochs VGA used the wrong PCI
vendor ID (0x4321 instead of 0x1234). Although this can hopefully be
fixed in the future, it is a problem for users of the current version,
not the least because to update the device ID the BIOS has to be
rebuilt in order to see BIOS output.
Add support for the 4321:1111 device number in addition to the
1234:1111 one.
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
---
drivers/gpu/drm/tiny/bochs.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 73415fa9ae0f..2ce3bd903b70 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -63,6 +63,7 @@ MODULE_PARM_DESC(defy, "default y resolution");
enum bochs_types {
BOCHS_QEMU_STDVGA,
+ BOCHS_SIMICS,
BOCHS_UNKNOWN,
};
@@ -695,6 +696,13 @@ static const struct pci_device_id bochs_pci_tbl[] = {
.subdevice = PCI_ANY_ID,
.driver_data = BOCHS_UNKNOWN,
},
+ {
+ .vendor = 0x4321,
+ .device = 0x1111,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = BOCHS_SIMICS,
+ },
{ /* end of list */ }
};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-15 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 1:06 [PATCH] drm/bochs: add Bochs PCI ID for Simics model H. Peter Anvin (Intel)
2021-09-15 6:29 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2021-09-08 17:17 [PATCH] x86/asm: pessimize the pre-initialization case in static_cpu_has() H. Peter Anvin (Intel)
2021-09-10 19:59 ` [PATCH v3 0/2] x86/asm: avoid register pressure from the init " H. Peter Anvin (Intel)
2021-09-10 19:59 ` [PATCH] drm/bochs: add Bochs PCI ID for Simics model H. Peter Anvin (Intel)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).