Re: [PATCH v2 06/13] mm: thp: introduce split_queue_lock/unlock{_irqsave}()

From: kernel test robot <lkp@intel.com>
To: Muchun Song <songmuchun@bytedance.com>,
	guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org,
	akpm@linux-foundation.org, shakeelb@google.com,
	vdavydov.dev@gmail.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, duanxiongchun@bytedance.com,
	fam.zheng@bytedance.com
Subject: Re: [PATCH v2 06/13] mm: thp: introduce split_queue_lock/unlock{_irqsave}()
Date: Fri, 17 Sep 2021 10:43:53 +0800	[thread overview]
Message-ID: <202109171013.Nsieqj9q-lkp@intel.com> (raw)
In-Reply-To: <20210916134748.67712-7-songmuchun@bytedance.com>

[-- Attachment #1: Type: text/plain, Size: 2676 bytes --]

Hi Muchun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tj-cgroup/for-next]
[also build test ERROR on linus/master v5.15-rc1]
[cannot apply to hnaz-mm/master next-20210916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: x86_64-randconfig-m001-20210916 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/38a59259cef424526ba9abba4aa87ae066948218
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
        git checkout 38a59259cef424526ba9abba4aa87ae066948218
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> mm/huge_memory.c:516:1: error: expected identifier or '(' before '+' token
     516 | +static inline struct mem_cgroup *split_queue_memcg(struct deferred_split *queue)
         | ^
   mm/huge_memory.c: In function 'deferred_split_huge_page':
>> mm/huge_memory.c:2816:10: error: implicit declaration of function 'split_queue_memcg'; did you mean 'split_queue_lock'? [-Werror=implicit-function-declaration]
    2816 |  memcg = split_queue_memcg(ds_queue);
         |          ^~~~~~~~~~~~~~~~~
         |          split_queue_lock
>> mm/huge_memory.c:2816:8: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    2816 |  memcg = split_queue_memcg(ds_queue);
         |        ^
   cc1: some warnings being treated as errors

vim +516 mm/huge_memory.c

   508	
   509	static inline struct deferred_split *page_memcg_split_queue(struct page *head)
   510	{
   511		struct mem_cgroup *memcg = page_memcg(head);
   512	
   513		return memcg ? &memcg->deferred_split_queue : NULL;
   514	}
   515	#else
 > 516	+static inline struct mem_cgroup *split_queue_memcg(struct deferred_split *queue)
   517	{
   518		return NULL;
   519	}
   520	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35196 bytes --]