From: Serge Semin <fancer.lancer@gmail.com>
To: Apurva Nandan <a-nandan@ti.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
michael@walle.cc
Subject: Re: [PATCH v2 2/2] dt-bindings: snps,dw-apb-ssi: Use 'flash' node name instead of 'spi-flash' in example
Date: Mon, 20 Sep 2021 17:44:04 +0300 [thread overview]
Message-ID: <20210920144404.5vhynfdfukabxgav@mobilestation> (raw)
In-Reply-To: <20210920142713.129295-3-a-nandan@ti.com>
On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote:
> Change the nodename in the example with spi-nand from 'spi-flash@1'
> to 'flash@1' to make the schema uniform with both spi-nand and spi-nor
> flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes,
> so make the spi-nand examples in dt-bindings use it too for uniformity.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems reasonable.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index ca91201a9926..d7e08b03e204 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -171,7 +171,7 @@ examples:
> cs-gpios = <&gpio0 13 0>,
> <&gpio0 14 0>;
> rx-sample-delay-ns = <3>;
> - spi-flash@1 {
> + flash@1 {
> compatible = "spi-nand";
> reg = <1>;
> rx-sample-delay-ns = <7>;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-20 14:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:27 [PATCH v2 0/2] dt-bindings: mtd: spi-nand: Convert to DT schema Apurva Nandan
2021-09-20 14:27 ` [PATCH v2 1/2] dt-bindings: mtd: spi-nand: Convert to DT schema format Apurva Nandan
2021-09-20 15:06 ` Serge Semin
2021-09-20 17:36 ` Pratyush Yadav
2021-09-20 21:16 ` Rob Herring
2021-09-21 13:42 ` Apurva Nandan
2021-09-21 19:16 ` Rob Herring
2021-09-22 8:31 ` Miquel Raynal
2021-09-20 19:26 ` Rob Herring
2021-09-20 14:27 ` [PATCH v2 2/2] dt-bindings: snps,dw-apb-ssi: Use 'flash' node name instead of 'spi-flash' in example Apurva Nandan
2021-09-20 14:44 ` Serge Semin [this message]
2021-09-20 14:44 ` Mark Brown
2021-09-20 19:26 ` Rob Herring
2021-09-20 21:19 ` Rob Herring
2021-09-21 13:44 ` Apurva Nandan
2021-09-21 15:25 ` (subset) [PATCH v2 0/2] dt-bindings: mtd: spi-nand: Convert to DT schema Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920144404.5vhynfdfukabxgav@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=a-nandan@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).