From: Pratyush Yadav <p.yadav@ti.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Apurva Nandan <a-nandan@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<michael@walle.cc>
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: spi-nand: Convert to DT schema format
Date: Mon, 20 Sep 2021 23:06:15 +0530 [thread overview]
Message-ID: <20210920173613.oqk6lnmipabkt25s@ti.com> (raw)
In-Reply-To: <20210920150651.vvdhennblwhdi3jw@mobilestation>
On 20/09/21 06:06PM, Serge Semin wrote:
> Hello Apurva
>
> On Mon, Sep 20, 2021 at 07:57:12PM +0530, Apurva Nandan wrote:
> > Convert spi-nand.txt binding to YAML format with an added example.
> >
> > Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> > ---
> > .../devicetree/bindings/mtd/spi-nand.txt | 5 --
> > .../devicetree/bindings/mtd/spi-nand.yaml | 62 +++++++++++++++++++
> > 2 files changed, 62 insertions(+), 5 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> > create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
[...]
>
> > + spi-max-frequency: true
> > + spi-rx-bus-width: true
> > + spi-tx-bus-width: true
> > + rx-sample-delay-ns: true
>
> Since it's an SPI-client device there are more than these properties
> could be set for it. See the SPI-controller bindings schema:
> Documentation/devicetree/bindings/spi/spi-controller.yaml
> So there is two possible ways to make it more generic:
> 1) Detach the spi-client part from the spi-controller.yaml bindings
> into a dedicated DT-schema file and refer to that new scheme from
> here.
> 2) Forget about these controller-specific properties and let the
> parental SPI-controller bindings parsing them. Of course there must be
> at least one of the next properties declared for it to work:
> {unevaluatedProperties, additionalProperties}.
I proposed a patch series [0] to fix this for SPI NOR, which can be used
here as well. A re-roll is long overdue though. Let me see when I can
find time to get to it. In the meantime, this should be fine IMO.
[0] https://patchwork.kernel.org/project/spi-devel-general/list/?series=497129&state=%2A&archive=both
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-09-20 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:27 [PATCH v2 0/2] dt-bindings: mtd: spi-nand: Convert to DT schema Apurva Nandan
2021-09-20 14:27 ` [PATCH v2 1/2] dt-bindings: mtd: spi-nand: Convert to DT schema format Apurva Nandan
2021-09-20 15:06 ` Serge Semin
2021-09-20 17:36 ` Pratyush Yadav [this message]
2021-09-20 21:16 ` Rob Herring
2021-09-21 13:42 ` Apurva Nandan
2021-09-21 19:16 ` Rob Herring
2021-09-22 8:31 ` Miquel Raynal
2021-09-20 19:26 ` Rob Herring
2021-09-20 14:27 ` [PATCH v2 2/2] dt-bindings: snps,dw-apb-ssi: Use 'flash' node name instead of 'spi-flash' in example Apurva Nandan
2021-09-20 14:44 ` Serge Semin
2021-09-20 14:44 ` Mark Brown
2021-09-20 19:26 ` Rob Herring
2021-09-20 21:19 ` Rob Herring
2021-09-21 13:44 ` Apurva Nandan
2021-09-21 15:25 ` (subset) [PATCH v2 0/2] dt-bindings: mtd: spi-nand: Convert to DT schema Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920173613.oqk6lnmipabkt25s@ti.com \
--to=p.yadav@ti.com \
--cc=a-nandan@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).