* [PATCH] gfs2: Fix unused value warning in do_gfs2_set_flags()
@ 2021-09-20 19:05 Tim Gardner
2021-10-13 14:30 ` Andreas Gruenbacher
0 siblings, 1 reply; 2+ messages in thread
From: Tim Gardner @ 2021-09-20 19:05 UTC (permalink / raw)
To: cluster-devel
Cc: tim.gardner, Bob Peterson, Andreas Gruenbacher, linux-kernel
Coverity complains of an unused value:
CID 119623 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value -1 to error here, but that stored value is
overwritten before it can be used.
237 error = -EPERM;
Fix it by removing the assignment.
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
fs/gfs2/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 354cf85154a6..7e09d2168030 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -234,7 +234,6 @@ static int do_gfs2_set_flags(struct inode *inode, u32 reqflags, u32 mask)
if ((new_flags ^ flags) == 0)
goto out;
- error = -EPERM;
if (!IS_IMMUTABLE(inode)) {
error = gfs2_permission(&init_user_ns, inode, MAY_WRITE);
if (error)
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-13 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 19:05 [PATCH] gfs2: Fix unused value warning in do_gfs2_set_flags() Tim Gardner
2021-10-13 14:30 ` Andreas Gruenbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).