linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: fix SAI sub nodes register range
@ 2021-09-24 16:02 Olivier Moysan
  2021-10-15 13:01 ` Alexandre TORGUE
  0 siblings, 1 reply; 2+ messages in thread
From: Olivier Moysan @ 2021-09-24 16:02 UTC (permalink / raw)
  To: Alexandre Torgue, Maxime Coquelin, Olivier Moysan, Rob Herring
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32, Olivier Moysan

The STM32 SAI subblocks registers offsets are in the range
0x0004 (SAIx_CR1) to 0x0020 (SAIx_DR).
The corresponding range length is 0x20 instead of 0x1c.
Change reg property accordingly.

Fixes: 5afd65c3a060 ("ARM: dts: stm32: add sai support on stm32mp157c")

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index bd289bf5d269..6992a4b0ba79 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -824,7 +824,7 @@
 				#sound-dai-cells = <0>;
 
 				compatible = "st,stm32-sai-sub-a";
-				reg = <0x4 0x1c>;
+				reg = <0x4 0x20>;
 				clocks = <&rcc SAI1_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 87 0x400 0x01>;
@@ -834,7 +834,7 @@
 			sai1b: audio-controller@4400a024 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-b";
-				reg = <0x24 0x1c>;
+				reg = <0x24 0x20>;
 				clocks = <&rcc SAI1_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 88 0x400 0x01>;
@@ -855,7 +855,7 @@
 			sai2a: audio-controller@4400b004 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-a";
-				reg = <0x4 0x1c>;
+				reg = <0x4 0x20>;
 				clocks = <&rcc SAI2_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 89 0x400 0x01>;
@@ -865,7 +865,7 @@
 			sai2b: audio-controller@4400b024 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-b";
-				reg = <0x24 0x1c>;
+				reg = <0x24 0x20>;
 				clocks = <&rcc SAI2_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 90 0x400 0x01>;
@@ -886,7 +886,7 @@
 			sai3a: audio-controller@4400c004 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-a";
-				reg = <0x04 0x1c>;
+				reg = <0x04 0x20>;
 				clocks = <&rcc SAI3_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 113 0x400 0x01>;
@@ -896,7 +896,7 @@
 			sai3b: audio-controller@4400c024 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-b";
-				reg = <0x24 0x1c>;
+				reg = <0x24 0x20>;
 				clocks = <&rcc SAI3_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 114 0x400 0x01>;
@@ -1271,7 +1271,7 @@
 			sai4a: audio-controller@50027004 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-a";
-				reg = <0x04 0x1c>;
+				reg = <0x04 0x20>;
 				clocks = <&rcc SAI4_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 99 0x400 0x01>;
@@ -1281,7 +1281,7 @@
 			sai4b: audio-controller@50027024 {
 				#sound-dai-cells = <0>;
 				compatible = "st,stm32-sai-sub-b";
-				reg = <0x24 0x1c>;
+				reg = <0x24 0x20>;
 				clocks = <&rcc SAI4_K>;
 				clock-names = "sai_ck";
 				dmas = <&dmamux1 100 0x400 0x01>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: stm32: fix SAI sub nodes register range
  2021-09-24 16:02 [PATCH] ARM: dts: stm32: fix SAI sub nodes register range Olivier Moysan
@ 2021-10-15 13:01 ` Alexandre TORGUE
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre TORGUE @ 2021-10-15 13:01 UTC (permalink / raw)
  To: Olivier Moysan, Maxime Coquelin, Olivier Moysan, Rob Herring
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32

On 9/24/21 6:02 PM, Olivier Moysan wrote:
> The STM32 SAI subblocks registers offsets are in the range
> 0x0004 (SAIx_CR1) to 0x0020 (SAIx_DR).
> The corresponding range length is 0x20 instead of 0x1c.
> Change reg property accordingly.
> 
> Fixes: 5afd65c3a060 ("ARM: dts: stm32: add sai support on stm32mp157c")
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>   arch/arm/boot/dts/stm32mp151.dtsi | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index bd289bf5d269..6992a4b0ba79 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -824,7 +824,7 @@
>   				#sound-dai-cells = <0>;
>   
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x4 0x1c>;
> +				reg = <0x4 0x20>;
>   				clocks = <&rcc SAI1_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 87 0x400 0x01>;
> @@ -834,7 +834,7 @@
>   			sai1b: audio-controller@4400a024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI1_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 88 0x400 0x01>;
> @@ -855,7 +855,7 @@
>   			sai2a: audio-controller@4400b004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x4 0x1c>;
> +				reg = <0x4 0x20>;
>   				clocks = <&rcc SAI2_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 89 0x400 0x01>;
> @@ -865,7 +865,7 @@
>   			sai2b: audio-controller@4400b024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI2_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 90 0x400 0x01>;
> @@ -886,7 +886,7 @@
>   			sai3a: audio-controller@4400c004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x04 0x1c>;
> +				reg = <0x04 0x20>;
>   				clocks = <&rcc SAI3_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 113 0x400 0x01>;
> @@ -896,7 +896,7 @@
>   			sai3b: audio-controller@4400c024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI3_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 114 0x400 0x01>;
> @@ -1271,7 +1271,7 @@
>   			sai4a: audio-controller@50027004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x04 0x1c>;
> +				reg = <0x04 0x20>;
>   				clocks = <&rcc SAI4_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 99 0x400 0x01>;
> @@ -1281,7 +1281,7 @@
>   			sai4b: audio-controller@50027024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI4_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 100 0x400 0x01>;
> 

Applied on stm32-next.

Thanks
Alex


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-15 13:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 16:02 [PATCH] ARM: dts: stm32: fix SAI sub nodes register range Olivier Moysan
2021-10-15 13:01 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).