* [PATCH 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe()
@ 2021-09-27 8:32 Cai Huoqing
2021-09-27 8:32 ` [PATCH 2/4] iio: light: cm36651: " Cai Huoqing
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-27 8:32 UTC (permalink / raw)
To: caihuoqing
Cc: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen, Linus Walleij,
linux-iio, linux-kernel
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/iio/light/cm3605.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c
index 4c83953672be..0b90564213e8 100644
--- a/drivers/iio/light/cm3605.c
+++ b/drivers/iio/light/cm3605.c
@@ -211,10 +211,10 @@ static int cm3605_probe(struct platform_device *pdev)
}
cm3605->vdd = devm_regulator_get(dev, "vdd");
- if (IS_ERR(cm3605->vdd)) {
- dev_err(dev, "failed to get VDD regulator\n");
- return PTR_ERR(cm3605->vdd);
- }
+ if (IS_ERR(cm3605->vdd))
+ return dev_err_probe(dev, PTR_ERR(cm3605->vdd),
+ "failed to get VDD regulator\n");
+
ret = regulator_enable(cm3605->vdd);
if (ret) {
dev_err(dev, "failed to enable VDD regulator\n");
@@ -223,8 +223,7 @@ static int cm3605_probe(struct platform_device *pdev)
cm3605->aset = devm_gpiod_get(dev, "aset", GPIOD_OUT_HIGH);
if (IS_ERR(cm3605->aset)) {
- dev_err(dev, "no ASET GPIO\n");
- ret = PTR_ERR(cm3605->aset);
+ ret = dev_err_probe(dev, PTR_ERR(cm3605->aset), "no ASET GPIO\n");
goto out_disable_vdd;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/4] iio: light: cm36651: Make use of the helper function dev_err_probe()
2021-09-27 8:32 [PATCH 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
@ 2021-09-27 8:32 ` Cai Huoqing
2021-09-27 8:32 ` [PATCH 3/4] iio: light: gp2ap002: " Cai Huoqing
2021-09-27 8:32 ` [PATCH 4/4] iio: light: noa1305: " Cai Huoqing
2 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-27 8:32 UTC (permalink / raw)
To: caihuoqing
Cc: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen, Linus Walleij,
linux-iio, linux-kernel
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/iio/light/cm36651.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
index fd83a19929bc..c7cc4b0fe8b2 100644
--- a/drivers/iio/light/cm36651.c
+++ b/drivers/iio/light/cm36651.c
@@ -632,10 +632,10 @@ static int cm36651_probe(struct i2c_client *client,
cm36651 = iio_priv(indio_dev);
cm36651->vled_reg = devm_regulator_get(&client->dev, "vled");
- if (IS_ERR(cm36651->vled_reg)) {
- dev_err(&client->dev, "get regulator vled failed\n");
- return PTR_ERR(cm36651->vled_reg);
- }
+ if (IS_ERR(cm36651->vled_reg))
+ return dev_err_probe(&client->dev,
+ PTR_ERR(cm36651->vled_reg),
+ "get regulator vled failed\n");
ret = regulator_enable(cm36651->vled_reg);
if (ret) {
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/4] iio: light: gp2ap002: Make use of the helper function dev_err_probe()
2021-09-27 8:32 [PATCH 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-27 8:32 ` [PATCH 2/4] iio: light: cm36651: " Cai Huoqing
@ 2021-09-27 8:32 ` Cai Huoqing
2021-09-27 8:32 ` [PATCH 4/4] iio: light: noa1305: " Cai Huoqing
2 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-27 8:32 UTC (permalink / raw)
To: caihuoqing
Cc: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen, Linus Walleij,
linux-iio, linux-kernel
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/iio/light/gp2ap002.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
index f960be7d4001..724a3928ead1 100644
--- a/drivers/iio/light/gp2ap002.c
+++ b/drivers/iio/light/gp2ap002.c
@@ -521,15 +521,14 @@ static int gp2ap002_probe(struct i2c_client *client,
}
gp2ap002->vdd = devm_regulator_get(dev, "vdd");
- if (IS_ERR(gp2ap002->vdd)) {
- dev_err(dev, "failed to get VDD regulator\n");
- return PTR_ERR(gp2ap002->vdd);
- }
+ if (IS_ERR(gp2ap002->vdd))
+ return dev_err_probe(dev, PTR_ERR(gp2ap002->vdd),
+ "failed to get VDD regulator\n");
+
gp2ap002->vio = devm_regulator_get(dev, "vio");
- if (IS_ERR(gp2ap002->vio)) {
- dev_err(dev, "failed to get VIO regulator\n");
- return PTR_ERR(gp2ap002->vio);
- }
+ if (IS_ERR(gp2ap002->vio))
+ return dev_err_probe(dev, PTR_ERR(gp2ap002->vio),
+ "failed to get VIO regulator\n");
/* Operating voltage 2.4V .. 3.6V according to datasheet */
ret = regulator_set_voltage(gp2ap002->vdd, 2400000, 3600000);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 4/4] iio: light: noa1305: Make use of the helper function dev_err_probe()
2021-09-27 8:32 [PATCH 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-27 8:32 ` [PATCH 2/4] iio: light: cm36651: " Cai Huoqing
2021-09-27 8:32 ` [PATCH 3/4] iio: light: gp2ap002: " Cai Huoqing
@ 2021-09-27 8:32 ` Cai Huoqing
2 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-27 8:32 UTC (permalink / raw)
To: caihuoqing
Cc: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen, Linus Walleij,
linux-iio, linux-kernel
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/iio/light/noa1305.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
index a308fbc2fc7b..71a322227429 100644
--- a/drivers/iio/light/noa1305.c
+++ b/drivers/iio/light/noa1305.c
@@ -217,10 +217,10 @@ static int noa1305_probe(struct i2c_client *client,
priv = iio_priv(indio_dev);
priv->vin_reg = devm_regulator_get(&client->dev, "vin");
- if (IS_ERR(priv->vin_reg)) {
- dev_err(&client->dev, "get regulator vin failed\n");
- return PTR_ERR(priv->vin_reg);
- }
+ if (IS_ERR(priv->vin_reg))
+ return dev_err_probe(&client->dev,
+ PTR_ERR(priv->vin_reg),
+ "get regulator vin failed\n");
ret = regulator_enable(priv->vin_reg);
if (ret) {
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-27 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 8:32 [PATCH 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-27 8:32 ` [PATCH 2/4] iio: light: cm36651: " Cai Huoqing
2021-09-27 8:32 ` [PATCH 3/4] iio: light: gp2ap002: " Cai Huoqing
2021-09-27 8:32 ` [PATCH 4/4] iio: light: noa1305: " Cai Huoqing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).