From: Maxime Ripard <maxime@cerno.tech>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Harry Wentland <harry.wentland@amd.com>,
Sam Ravnborg <sam@ravnborg.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD
Date: Mon, 27 Sep 2021 19:00:34 +0200 [thread overview]
Message-ID: <20210927170034.mhv5r2r5gcojc7yn@gilmour> (raw)
In-Reply-To: <dd2356790b774c7885afecc9d29783cb51a26e6d.1632761068.git.hns@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
Hi,
On Mon, Sep 27, 2021 at 06:44:23PM +0200, H. Nikolaus Schaller wrote:
> It appears that dw-hdmi plugin detection is not properly
> propagated unless we call drm_kms_helper_hotplug_event().
>
> Maybe drm_bridge_hpd_notify should have been setup to
> call this.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index f082e14320e1..edea04f80576 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3018,6 +3018,8 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id)
> if (hdmi->bridge.dev) {
> drm_helper_hpd_irq_event(hdmi->bridge.dev);
> drm_bridge_hpd_notify(&hdmi->bridge, status);
> +
> + drm_kms_helper_hotplug_event(hdmi->bridge.dev);
drm_kms_helper_hotplug_event is already called from drm_helper_hpd_irq_event
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-09-27 17:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 16:44 [PATCH v4 00/10] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 01/10] drm/ingenic: Fix drm_init error path if IPU was registered H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller
2021-09-28 9:35 ` Paul Cercueil
2021-09-28 10:21 ` H. Nikolaus Schaller
2021-09-28 12:06 ` H. Nikolaus Schaller
2021-09-29 13:25 ` H. Nikolaus Schaller
2021-09-29 14:30 ` Paul Cercueil
2021-09-29 14:42 ` H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller
2021-09-27 17:07 ` maxime
2021-09-28 8:59 ` H. Nikolaus Schaller
2021-09-28 9:18 ` Maxime Ripard
2021-09-28 9:34 ` H. Nikolaus Schaller
2021-09-28 2:01 ` Rob Herring
2021-09-27 16:44 ` [PATCH v4 04/10] drm/bridge: synopsis: Add mode_fixup and bridge timings support H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD H. Nikolaus Schaller
2021-09-27 17:00 ` Maxime Ripard [this message]
2021-09-27 17:53 ` H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller
2021-09-27 17:08 ` Maxime Ripard
2021-09-28 13:02 ` Neil Armstrong
2021-09-28 13:35 ` H. Nikolaus Schaller
2021-09-28 14:10 ` Paul Cercueil
2021-09-27 16:44 ` [PATCH v4 07/10] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 08/10] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 09/10] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
2021-09-27 16:44 ` [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features H. Nikolaus Schaller
2021-09-28 9:58 ` Paul Cercueil
2021-09-28 10:06 ` H. Nikolaus Schaller
2021-09-28 11:50 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927170034.mhv5r2r5gcojc7yn@gilmour \
--to=maxime@cerno.tech \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=hns@goldelico.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).