* linux-next: build failure after merge of the crypto tree
@ 2021-09-27 4:32 Stephen Rothwell
2021-09-27 11:23 ` [PATCH] crypto: api - Export crypto_boot_test_finished Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-09-27 4:32 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
Hi all,
After merging the crypto tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:
ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!
Caused by commit
adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] crypto: api - Export crypto_boot_test_finished
2021-09-27 4:32 linux-next: build failure after merge of the crypto tree Stephen Rothwell
@ 2021-09-27 11:23 ` Herbert Xu
2021-09-28 5:16 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Herbert Xu @ 2021-09-27 11:23 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-crypto, linux-kernel, linux-next
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> [-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --]
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!
>
> Caused by commit
>
> adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
>
> I have reverted that commit for today.
Oops, does this patch fix the problem?
---8<---
We need to export crypto_boot_test_finished in case api.c is
built-in while algapi.c is built as a module.
Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/api.c b/crypto/api.c
index 1cf1f03347cc..ee5991fe11f8 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -32,6 +32,7 @@ BLOCKING_NOTIFIER_HEAD(crypto_chain);
EXPORT_SYMBOL_GPL(crypto_chain);
DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished);
+EXPORT_SYMBOL_GPL(crypto_boot_test_finished);
static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg);
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] crypto: api - Export crypto_boot_test_finished
2021-09-27 11:23 ` [PATCH] crypto: api - Export crypto_boot_test_finished Herbert Xu
@ 2021-09-28 5:16 ` Stephen Rothwell
2021-10-25 6:28 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-09-28 5:16 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto, linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi Herbert,
On Mon, 27 Sep 2021 19:23:42 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Oops, does this patch fix the problem?
Yes, that fixes my build, thanks.
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # ppc32 build
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: api - Export crypto_boot_test_finished
2021-09-28 5:16 ` Stephen Rothwell
@ 2021-10-25 6:28 ` Michael Ellerman
2021-10-26 4:38 ` Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2021-10-25 6:28 UTC (permalink / raw)
To: Stephen Rothwell, Herbert Xu; +Cc: linux-crypto, linux-kernel, linux-next
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Herbert,
>
> On Mon, 27 Sep 2021 19:23:42 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>
>> Oops, does this patch fix the problem?
>
> Yes, that fixes my build, thanks.
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # ppc32 build
It fixes the build, but modules_install still fails:
$ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures
$ git show e42dff467ee6 | patch -p1 # apply fixup patch
patching file crypto/api.c
$ make -s -j $(nproc) modules
$ make -s modules_install
depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto
depmod: ERROR: Found 2 modules in dependency cycles!
make: *** [Makefile:1801: modules_install] Error 1
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: api - Export crypto_boot_test_finished
2021-10-25 6:28 ` Michael Ellerman
@ 2021-10-26 4:38 ` Herbert Xu
2021-10-29 6:09 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Herbert Xu @ 2021-10-26 4:38 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Stephen Rothwell, linux-crypto, linux-kernel, linux-next
On Mon, Oct 25, 2021 at 05:28:24PM +1100, Michael Ellerman wrote:
>
> It fixes the build, but modules_install still fails:
>
> $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
> HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures
Sorry, the fix is in the queue:
https://patchwork.kernel.org/project/linux-crypto/patch/20211019132802.GA14233@gondor.apana.org.au/
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: api - Export crypto_boot_test_finished
2021-10-26 4:38 ` Herbert Xu
@ 2021-10-29 6:09 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2021-10-29 6:09 UTC (permalink / raw)
To: Herbert Xu; +Cc: Stephen Rothwell, linux-crypto, linux-kernel, linux-next
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Mon, Oct 25, 2021 at 05:28:24PM +1100, Michael Ellerman wrote:
>>
>> It fixes the build, but modules_install still fails:
>>
>> $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
>> HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures
>
> Sorry, the fix is in the queue:
>
> https://patchwork.kernel.org/project/linux-crypto/patch/20211019132802.GA14233@gondor.apana.org.au/
Thanks, that fixes it for me.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-29 6:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 4:32 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2021-09-27 11:23 ` [PATCH] crypto: api - Export crypto_boot_test_finished Herbert Xu
2021-09-28 5:16 ` Stephen Rothwell
2021-10-25 6:28 ` Michael Ellerman
2021-10-26 4:38 ` Herbert Xu
2021-10-29 6:09 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).