From: Xiaoming Ni <nixiaoming@huawei.com>
To: <oss@buserror.net>, <mpe@ellerman.id.au>,
<benh@kernel.crashing.org>, <paulus@samba.org>,
<paul.gortmaker@windriver.com>, <chenhui.zhao@freescale.com>,
<Yuantian.Tang@feescale.com>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Cc: <wangle6@huawei.com>, <liuwenliang@huawei.com>,
<chenjianguo3@huawei.com>, <nixiaoming@huawei.com>
Subject: [PATCH v2 1/2] powerpc:85xx:Fix oops when mpc85xx_smp_guts_ids node cannot be found
Date: Wed, 29 Sep 2021 11:36:45 +0800 [thread overview]
Message-ID: <20210929033646.39630-2-nixiaoming@huawei.com> (raw)
In-Reply-To: <20210929033646.39630-1-nixiaoming@huawei.com>
When the field described in mpc85xx_smp_guts_ids[] is not configured in
dtb, the mpc85xx_setup_pmc() does not assign a value to the "guts"
variable. As a result, the oops is triggered when
mpc85xx_freeze_time_base() is executed.
Fixes:56f1ba280719 ("powerpc/mpc85xx: refactor the PM operations")
Cc: stable@vger.kernel.org #v4.6
Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
---
arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c b/arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c
index 7c0133f558d0..ffa8a7a6a2db 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c
@@ -94,9 +94,8 @@ int __init mpc85xx_setup_pmc(void)
pr_err("Could not map guts node address\n");
return -ENOMEM;
}
+ qoriq_pm_ops = &mpc85xx_pm_ops;
}
- qoriq_pm_ops = &mpc85xx_pm_ops;
-
return 0;
}
--
2.27.0
next prev parent reply other threads:[~2021-09-29 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 2:51 [PATCH] powerpc:85xx: fix timebase sync issue when CONFIG_HOTPLUG_CPU=n Xiaoming Ni
2021-09-26 12:34 ` Xiaoming Ni
2021-09-29 3:36 ` [PATCH v2 0/2] " Xiaoming Ni
2021-09-29 3:36 ` Xiaoming Ni [this message]
2021-09-29 3:36 ` [PATCH v2 2/2] " Xiaoming Ni
2021-10-11 12:06 ` [PATCH v2 0/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929033646.39630-2-nixiaoming@huawei.com \
--to=nixiaoming@huawei.com \
--cc=Yuantian.Tang@feescale.com \
--cc=benh@kernel.crashing.org \
--cc=chenhui.zhao@freescale.com \
--cc=chenjianguo3@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liuwenliang@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=wangle6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).