* [PATCH] media: atomisp: add missing return type (fix -Werror=return-type)
@ 2021-09-29 12:26 Paolo Pisati
2021-09-29 13:11 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Pisati @ 2021-09-29 12:26 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman, Pavel Skripkin
Cc: linux-media, linux-staging, linux-kernel
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
1649 | }
| ^
cc1: some warnings being treated as errors
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
.../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..f36dadb5230a 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
default:
return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
}
+
+ return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
}
// Test flags and set structure.
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: atomisp: add missing return type (fix -Werror=return-type)
2021-09-29 12:26 [PATCH] media: atomisp: add missing return type (fix -Werror=return-type) Paolo Pisati
@ 2021-09-29 13:11 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-09-29 13:11 UTC (permalink / raw)
To: Paolo Pisati
Cc: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
Pavel Skripkin, linux-media, linux-staging, linux-kernel
On Wed, Sep 29, 2021 at 02:26:38PM +0200, Paolo Pisati wrote:
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 1649 | }
> | ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
This was fixed a long time ago. Please work against an up-to-date tree.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-29 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 12:26 [PATCH] media: atomisp: add missing return type (fix -Werror=return-type) Paolo Pisati
2021-09-29 13:11 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).