From: Jonathan Cameron <jic23@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Kevin Tsai <ktsai@capellamicro.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe()
Date: Wed, 29 Sep 2021 17:00:35 +0100 [thread overview]
Message-ID: <20210929170035.619212d4@jic23-huawei> (raw)
In-Reply-To: <20210928014156.1491-1-caihuoqing@baidu.com>
On Tue, 28 Sep 2021 09:41:52 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Hi Cai,
This driver has some more cases where we should potentially do something
like this.
It handles the lack of availability of an IIO channel in line 199
by converting an -ENODEV to an -EPROBE_DEFER.
Also platform_get_irq() can return -EPROBE_DEFER and the driver
isn't currently handling that properly.
Both changes are of a more involved nature than the simple conversions you
have here though, so perhaps a follow up patch?
The parts you here look good to me.
Thanks,
Jonathan
> ---
> drivers/iio/light/cm3605.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c
> index 4c83953672be..0b90564213e8 100644
> --- a/drivers/iio/light/cm3605.c
> +++ b/drivers/iio/light/cm3605.c
> @@ -211,10 +211,10 @@ static int cm3605_probe(struct platform_device *pdev)
> }
>
> cm3605->vdd = devm_regulator_get(dev, "vdd");
> - if (IS_ERR(cm3605->vdd)) {
> - dev_err(dev, "failed to get VDD regulator\n");
> - return PTR_ERR(cm3605->vdd);
> - }
> + if (IS_ERR(cm3605->vdd))
> + return dev_err_probe(dev, PTR_ERR(cm3605->vdd),
> + "failed to get VDD regulator\n");
> +
> ret = regulator_enable(cm3605->vdd);
> if (ret) {
> dev_err(dev, "failed to enable VDD regulator\n");
> @@ -223,8 +223,7 @@ static int cm3605_probe(struct platform_device *pdev)
>
> cm3605->aset = devm_gpiod_get(dev, "aset", GPIOD_OUT_HIGH);
> if (IS_ERR(cm3605->aset)) {
> - dev_err(dev, "no ASET GPIO\n");
> - ret = PTR_ERR(cm3605->aset);
> + ret = dev_err_probe(dev, PTR_ERR(cm3605->aset), "no ASET GPIO\n");
> goto out_disable_vdd;
> }
>
prev parent reply other threads:[~2021-09-29 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 1:41 [PATCH v2 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-28 1:41 ` [PATCH v2 2/4] iio: light: cm36651: " Cai Huoqing
2021-10-07 17:36 ` Jonathan Cameron
2021-09-28 1:41 ` [PATCH v2 3/4] iio: light: gp2ap002: " Cai Huoqing
2021-09-28 13:48 ` Linus Walleij
2021-09-29 16:08 ` Jonathan Cameron
2021-09-28 1:41 ` [PATCH v2 4/4] iio: light: noa1305: " Cai Huoqing
2021-10-07 17:38 ` Jonathan Cameron
2021-10-08 2:09 ` Cai Huoqing
2021-09-29 16:00 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929170035.619212d4@jic23-huawei \
--to=jic23@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).