From: Cai Huoqing <caihuoqing@baidu.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Kevin Tsai <ktsai@capellamicro.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] iio: light: noa1305: Make use of the helper function dev_err_probe()
Date: Fri, 8 Oct 2021 10:09:50 +0800 [thread overview]
Message-ID: <20211008020950.GA290@LAPTOP-UKSR4ENP.internal.baidu.com> (raw)
In-Reply-To: <20211007183826.67c0fed4@jic23-huawei>
On 07 10月 21 18:38:26, Jonathan Cameron wrote:
> On Tue, 28 Sep 2021 09:41:55 +0800
> Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Applied this patch to the togreg branch of iio.git and pushed out as
> testing for 0-day to try it out.
>
> Note I didn't pick up 1 and 3 from this series and will expect to see
> a v3 of those or reply to the relevant reviews.
Sure, I will resend some patches according to your feedback.
Just took my vacation during 1~7th Oct.
>
> Thanks,
>
> Jonathan
>
> > ---
> > v1->v2: Remove the separate line of PTR_ERR().
> >
> > drivers/iio/light/noa1305.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
> > index a308fbc2fc7b..71a322227429 100644
> > --- a/drivers/iio/light/noa1305.c
> > +++ b/drivers/iio/light/noa1305.c
> > @@ -217,10 +217,9 @@ static int noa1305_probe(struct i2c_client *client,
> > priv = iio_priv(indio_dev);
> >
> > priv->vin_reg = devm_regulator_get(&client->dev, "vin");
> > - if (IS_ERR(priv->vin_reg)) {
> > - dev_err(&client->dev, "get regulator vin failed\n");
> > - return PTR_ERR(priv->vin_reg);
> > - }
> > + if (IS_ERR(priv->vin_reg))
> > + return dev_err_probe(&client->dev, PTR_ERR(priv->vin_reg),
> > + "get regulator vin failed\n");
> >
> > ret = regulator_enable(priv->vin_reg);
> > if (ret) {
>
next prev parent reply other threads:[~2021-10-08 2:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 1:41 [PATCH v2 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-28 1:41 ` [PATCH v2 2/4] iio: light: cm36651: " Cai Huoqing
2021-10-07 17:36 ` Jonathan Cameron
2021-09-28 1:41 ` [PATCH v2 3/4] iio: light: gp2ap002: " Cai Huoqing
2021-09-28 13:48 ` Linus Walleij
2021-09-29 16:08 ` Jonathan Cameron
2021-09-28 1:41 ` [PATCH v2 4/4] iio: light: noa1305: " Cai Huoqing
2021-10-07 17:38 ` Jonathan Cameron
2021-10-08 2:09 ` Cai Huoqing [this message]
2021-09-29 16:00 ` [PATCH v2 1/4] iio: light: cm3605: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008020950.GA290@LAPTOP-UKSR4ENP.internal.baidu.com \
--to=caihuoqing@baidu.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).