From: Mark Brown <broonie@kernel.org>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: kernel@collabora.com, linux-spi@vger.kernel.org,
enric.balletbo@collabora.com, dafna3@gmail.com,
Mason Zhang <Mason.Zhang@mediatek.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] Revert "spi: modify set_cs_timing parameter"
Date: Thu, 30 Sep 2021 13:25:13 +0100 [thread overview]
Message-ID: <20210930122513.GX4199@sirena.org.uk> (raw)
In-Reply-To: <20210930120700.2564-1-dafna.hirschfeld@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
On Thu, Sep 30, 2021 at 02:07:00PM +0200, Dafna Hirschfeld wrote:
> This reverts commit 04e6bb0d6bb127bac929fb35edd2dd01613c9520.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
> This revert the commit 'spi: modify set_cs_timing parameter'
> and its following commit
> 'spi: mediatek: fix build warnning in set cs timing'.
Which is not what the commit message nor the paste of the full hash
claimed :/
> Those commits cause regression on mt8173 elm device. The EC either is not
> able to register or it sends numerous amount of errors:
> cros-ec-i2c-tunnel 1100a000.spi:ec@0:i2c-tunnel0: Error transferring EC i2c message -71
> cros-ec-spi spi0.0: EC failed to respond in time.
Do we have any analysis as to why? Do these devices use timing
parameters in some way for example, or do the values written out to the
device change in some way?
You've provided no analysis here so it's hard to tell if this is just
some random change that happens to change code generation slighly or if
there's some actual reason why this might fix something. I'll note that
as far as I can see there are no users of this API upstream so I'm
guessing that you've got some out of tree consumer driver which uses the
API, it's possible that there was some error in updating that driver to
the new interface which is causing the issue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-30 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:07 [PATCH] Revert "spi: modify set_cs_timing parameter" Dafna Hirschfeld
2021-09-30 12:25 ` Mark Brown [this message]
2021-09-30 12:36 ` Dafna Hirschfeld
2021-09-30 12:46 ` Mark Brown
2021-09-30 13:06 ` Dafna Hirschfeld
2021-09-30 13:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930122513.GX4199@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Mason.Zhang@mediatek.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).