From: Pingfan Liu <kernelfans@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Pingfan Liu <kernelfans@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Sami Tolvanen <samitolvanen@google.com>,
Julien Thierry <julien.thierry@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yuichi Ito <ito-yuichi@fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: [PATCHv3 0/3] arm64/irqentry: remove duplicate housekeeping of rcu
Date: Thu, 30 Sep 2021 21:17:05 +0800 [thread overview]
Message-ID: <20210930131708.35328-1-kernelfans@gmail.com> (raw)
When an IRQ is taken, some accounting needs to be performed to enter and
exit IRQ context around the IRQ handler. Historically arch code would
leave this to the irqchip or core IRQ code, but these days we want this
to happen in exception entry code, and architectures such as arm64 do
this.
Currently handle_domain_irq() performs this entry/exit accounting, and
if used on an architecture where the entry code also does this, the
entry/exit accounting will be performed twice per IRQ. This is
problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle()
depends on this happening once per IRQ, and will not detect quescent
periods correctly, leading to stall warnings.
As irqchip drivers which use handle_domain_irq() need to work on
architectures with or without their own entry/exit accounting, this
patch makes handle_domain_irq() conditionally perform the entry
accounting depending on a new HAVE_ARCH_IRQENTRY Kconfig symbol that
architectures can select if they perform this entry accounting
themselves.
V2 -> V3:
Drop other patches and concentrate on the purpose of [3-4/5] of V2.
And lift the level, where to add {irq_enter,exit}_rcu(), from the
interrupt controler to exception entry
History:
V1: https://lore.kernel.org/linux-arm-kernel/1607912752-12481-1-git-send-email-kernelfans@gmail.com
V2: https://lore.kernel.org/linux-arm-kernel/20210924132837.45994-1-kernelfans@gmail.com
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Joey Gouly <joey.gouly@arm.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: Julien Thierry <julien.thierry@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Yuichi Ito <ito-yuichi@fujitsu.com>
Cc: linux-kernel@vger.kernel.org
To: linux-arm-kernel@lists.infradead.org
Mark Rutland (1):
arm64: entry: refactor EL1 interrupt entry logic
Pingfan Liu (2):
kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch
optional
arm64/entry-common: supplement irq accounting
arch/arm64/Kconfig | 1 +
arch/arm64/kernel/entry-common.c | 48 +++++++++++++++++---------------
kernel/irq/Kconfig | 3 ++
kernel/irq/irqdesc.c | 4 +++
4 files changed, 34 insertions(+), 22 deletions(-)
--
2.31.1
next reply other threads:[~2021-09-30 13:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 13:17 Pingfan Liu [this message]
2021-09-30 13:17 ` [PATCHv3 1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional Pingfan Liu
2021-10-01 9:15 ` Marc Zyngier
2021-10-01 14:33 ` [PATCHv3 1/3] kernel/irq: make irq_{enter, exit}() " Pingfan Liu
2021-09-30 13:17 ` [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Pingfan Liu
2021-09-30 14:00 ` Mark Rutland
2021-10-01 2:27 ` Pingfan Liu
2021-10-01 9:21 ` Marc Zyngier
2021-10-01 14:12 ` Pingfan Liu
2021-09-30 13:17 ` [PATCHv3 3/3] arm64/entry-common: supplement irq accounting Pingfan Liu
2021-09-30 13:53 ` Mark Rutland
2021-10-01 9:22 ` Marc Zyngier
2021-10-01 14:10 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930131708.35328-1-kernelfans@gmail.com \
--to=kernelfans@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=ito-yuichi@fujitsu.com \
--cc=joey.gouly@arm.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=paulmck@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).