From: Pingfan Liu <kernelfans@gmail.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Sami Tolvanen <samitolvanen@google.com>,
Julien Thierry <julien.thierry@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yuichi Ito <ito-yuichi@fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 3/3] arm64/entry-common: supplement irq accounting
Date: Fri, 1 Oct 2021 22:10:57 +0800 [thread overview]
Message-ID: <YVcW8aGUEQ249smu@piliu.users.ipa.redhat.com> (raw)
In-Reply-To: <20210930135314.GC18258@lakrids.cambridge.arm.com>
On Thu, Sep 30, 2021 at 02:53:14PM +0100, Mark Rutland wrote:
> On Thu, Sep 30, 2021 at 09:17:08PM +0800, Pingfan Liu wrote:
> > At present, the irq entry/exit accounting, which is performed by
> > handle_domain_irq(), overlaps with arm64 exception entry code somehow.
> >
> > By supplementing irq accounting on arm64 exception entry code, the
> > accounting in handle_domain_irq() can be dropped totally by selecting
> > the macro HAVE_ARCH_IRQENTRY.
>
> I think we need to be more thorough and explain the specific problem and
> solution. How about we crib some wording from patch 1, and say:
>
> arm64: entry: avoid double-accounting IRQ RCU entry
>
> When an IRQ is taken, some accounting needs to be performed to enter
> and exit IRQ context around the IRQ handler. On arm64 some of this
> accounting is performed by both the architecture code and the IRQ
> domain code, resulting in calling rcu_irq_enter() twice per exception
> entry, violating the expectations of the core RCU code, and resulting
> in failing to identify quiescent periods correctly (e.g. in
> rcu_is_cpu_rrupt_from_idle()).
>
> To fix this, we must perform all the accounting from the architecture
> code. We prevent the IRQ domain code from performing any accounting by
> selecting HAVE_ARCH_IRQENTRY, and must call irq_enter_rcu() and
> irq_exit_rcu() around invoking the root IRQ handler.
>
> When we take a pNMI from a context with IRQs disabled, we'll perform
> the necessary accounting as part of arm64_enter_nmi() and
> arm64_exit_nmi(), and should only call irq_enter_rcu() and
> irq_exit_rcu() when we may have taken a regular interrupt.
>
It is a wonderful and elaborated log.
> That way it's clear what specifically the overlap is and the problem(s)
> it results in. The bit at the end explains why we don't call
> irq_{enter,exit}_rcu() when we're certain we've taken a pNMI.
>
I have learned much from the log you contribute to this series. I will keep
learning how to improve my ability of log. Thanks again!
> > Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> > Cc: "Paul E. McKenney" <paulmck@kernel.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Marc Zyngier <maz@kernel.org>
> > Cc: Joey Gouly <joey.gouly@arm.com>
> > Cc: Sami Tolvanen <samitolvanen@google.com>
> > Cc: Julien Thierry <julien.thierry@arm.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Yuichi Ito <ito-yuichi@fujitsu.com>
> > Cc: linux-kernel@vger.kernel.org
> > To: linux-arm-kernel@lists.infradead.org
> > ---
> > arch/arm64/Kconfig | 1 +
> > arch/arm64/kernel/entry-common.c | 4 ++++
> > 2 files changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 5c7ae4c3954b..d29bae38a951 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -98,6 +98,7 @@ config ARM64
> > select ARCH_HAS_UBSAN_SANITIZE_ALL
> > select ARM_AMBA
> > select ARM_ARCH_TIMER
> > + select HAVE_ARCH_IRQENTRY
>
> Please put this with the other HAVE_ARCH_* entries in
> arch/arm64/Kconfig -- it should be between HAVE_ARCH_HUGE_VMAP and
> HAVE_ARCH_JUMP_LABEL to keep that in alphabetical order.
>
OK, I will fix it in V4.
> With that and the title and commit message above:
>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
>
Thanks,
Pingfan
prev parent reply other threads:[~2021-10-01 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 13:17 [PATCHv3 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Pingfan Liu
2021-09-30 13:17 ` [PATCHv3 1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional Pingfan Liu
2021-10-01 9:15 ` Marc Zyngier
2021-10-01 14:33 ` [PATCHv3 1/3] kernel/irq: make irq_{enter, exit}() " Pingfan Liu
2021-09-30 13:17 ` [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Pingfan Liu
2021-09-30 14:00 ` Mark Rutland
2021-10-01 2:27 ` Pingfan Liu
2021-10-01 9:21 ` Marc Zyngier
2021-10-01 14:12 ` Pingfan Liu
2021-09-30 13:17 ` [PATCHv3 3/3] arm64/entry-common: supplement irq accounting Pingfan Liu
2021-09-30 13:53 ` Mark Rutland
2021-10-01 9:22 ` Marc Zyngier
2021-10-01 14:10 ` Pingfan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcW8aGUEQ249smu@piliu.users.ipa.redhat.com \
--to=kernelfans@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=ito-yuichi@fujitsu.com \
--cc=joey.gouly@arm.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=paulmck@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).