* [RFC PATCH] m68k: set a default value for MEMORY_RESERVE
@ 2021-10-03 0:02 Randy Dunlap
2021-10-04 6:47 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-10-03 0:02 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Geert Uytterhoeven, Greg Ungerer, linux-m68k
'make randconfig' can produce a .config file with
"CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
When a subsequent 'make all' is done, kconfig restarts the config
and prompts for a value for MEMORY_RESERVE. This breaks
scripting/automation where there is no interactive user input.
Add a default value for MEMORY_RESERVE. (Any integer value will
work here for kconfig.)
Fixes a kconfig warning:
.config:214:warning: symbol value '' invalid for MEMORY_RESERVE
* Restart config...
Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
arch/m68k/Kconfig.machine | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211001.orig/arch/m68k/Kconfig.machine
+++ linux-next-20211001/arch/m68k/Kconfig.machine
@@ -203,6 +203,7 @@ config INIT_LCD
config MEMORY_RESERVE
int "Memory reservation (MiB)"
depends on (UCSIMM || UCDIMM)
+ default 0
help
Reserve certain memory regions on 68x328 based boards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] m68k: set a default value for MEMORY_RESERVE
2021-10-03 0:02 [RFC PATCH] m68k: set a default value for MEMORY_RESERVE Randy Dunlap
@ 2021-10-04 6:47 ` Geert Uytterhoeven
2021-10-04 7:48 ` Greg Ungerer
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-10-04 6:47 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux Kernel Mailing List, Greg Ungerer, linux-m68k
On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> 'make randconfig' can produce a .config file with
> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
> When a subsequent 'make all' is done, kconfig restarts the config
> and prompts for a value for MEMORY_RESERVE. This breaks
> scripting/automation where there is no interactive user input.
>
> Add a default value for MEMORY_RESERVE. (Any integer value will
> work here for kconfig.)
>
> Fixes a kconfig warning:
>
> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
> * Restart config...
> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
busy.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] m68k: set a default value for MEMORY_RESERVE
2021-10-04 6:47 ` Geert Uytterhoeven
@ 2021-10-04 7:48 ` Greg Ungerer
0 siblings, 0 replies; 3+ messages in thread
From: Greg Ungerer @ 2021-10-04 7:48 UTC (permalink / raw)
To: Geert Uytterhoeven, Randy Dunlap; +Cc: Linux Kernel Mailing List, linux-m68k
On 4/10/21 4:47 pm, Geert Uytterhoeven wrote:
> On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> 'make randconfig' can produce a .config file with
>> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
>> When a subsequent 'make all' is done, kconfig restarts the config
>> and prompts for a value for MEMORY_RESERVE. This breaks
>> scripting/automation where there is no interactive user input.
>>
>> Add a default value for MEMORY_RESERVE. (Any integer value will
>> work here for kconfig.)
>>
>> Fixes a kconfig warning:
>>
>> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
>> * Restart config...
>> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
> As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
> busy.
Thanks Geert. No problem though, I'll pick this up and push to
the m68knommu git tree.
Regards
Greg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-03 0:02 [RFC PATCH] m68k: set a default value for MEMORY_RESERVE Randy Dunlap
2021-10-04 6:47 ` Geert Uytterhoeven
2021-10-04 7:48 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).