* [PATCH v3] ARM: imx6: disable the GIC CPU interface before calling stby-poweroff sequence
@ 2021-09-28 13:49 Oleksij Rempel
2021-10-05 5:58 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2021-09-28 13:49 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Oleksij Rempel, kernel, linux-arm-kernel, linux-kernel,
Fabio Estevam, linux-imx
Any pending interrupt can prevent entering standby based power off state.
To avoid it, disable the GIC CPU interface.
Fixes: 8148d2136002 ("ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/mach-imx/pm-imx6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
index 9244437cb1b9..f2ecca339910 100644
--- a/arch/arm/mach-imx/pm-imx6.c
+++ b/arch/arm/mach-imx/pm-imx6.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/irq.h>
#include <linux/genalloc.h>
+#include <linux/irqchip/arm-gic.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/of.h>
@@ -619,6 +620,7 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata
static void imx6_pm_stby_poweroff(void)
{
+ gic_cpu_if_down(0);
imx6_set_lpm(STOP_POWER_OFF);
imx6q_suspend_finish(0);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] ARM: imx6: disable the GIC CPU interface before calling stby-poweroff sequence
2021-09-28 13:49 [PATCH v3] ARM: imx6: disable the GIC CPU interface before calling stby-poweroff sequence Oleksij Rempel
@ 2021-10-05 5:58 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-10-05 5:58 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Sascha Hauer, kernel, linux-arm-kernel, linux-kernel,
Fabio Estevam, linux-imx
On Tue, Sep 28, 2021 at 03:49:40PM +0200, Oleksij Rempel wrote:
> Any pending interrupt can prevent entering standby based power off state.
> To avoid it, disable the GIC CPU interface.
>
> Fixes: 8148d2136002 ("ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 13:49 [PATCH v3] ARM: imx6: disable the GIC CPU interface before calling stby-poweroff sequence Oleksij Rempel
2021-10-05 5:58 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).