From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
kernel@collabora.com, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCHv5 0/2] Fix imx53-ppd UART configuration
Date: Tue, 5 Oct 2021 22:17:49 +0200 [thread overview]
Message-ID: <20211005201749.kpqkb5fxnavrqq2b@pengutronix.de> (raw)
In-Reply-To: <YLCx+jhg/j+JmBox@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 3378 bytes --]
Hello Greg,
[adding Rob and devicetree@vger to Cc:]
On Fri, May 28, 2021 at 11:03:54AM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 28, 2021 at 02:49:52AM +0200, Sebastian Reichel wrote:
> > On Sat, May 01, 2021 at 08:11:52AM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:
> > > > IMHO PATCHv4 was better, but in the end I don't have strong feelings
> > > > about this. Btw. I think this patchset is a good demonstration of
> > > > frustrating upstream kernel development can be considering PATCHv5
> > > > is basically the same as PATCHv1. Thanks for making us go in
> > > > circles :(
I was the one who objected the v1 approach. My frustration is that I
wasn't Cc:d in the later iterations of this patch set. And I also liked
v4 better :-\
> > > > Changes since PATCHv4:
> > > > * https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/
> > > > * use DT property instead of sysfs config option, like the initial patch
> > > > version did as requested by Greg.
> > > >
> > > > Changes since PATCHv3:
> > > > * https://lore.kernel.org/lkml/1539249903-6316-1-git-send-email-fabien.lahoudere@collabora.com/
> > > > * rewrote commit message to provide a lot more details why this is needed
> > > > * rebased to torvalds/master (5.12-rc1-dontuse), also applies on top of linux-next
> > > > * use sysfs_emit() instead of sprintf
> > > >
> > > > -- Sebastian
> > > >
> > > > Fabien Lahoudere (2):
> > > > serial: imx: Add DMA buffer configuration via DT
> > > > ARM: dts: imx53-ppd: add dma-info nodes
> > > >
> > > > .../bindings/serial/fsl-imx-uart.yaml | 12 +++++++++
> > > > arch/arm/boot/dts/imx53-ppd.dts | 2 ++
> > > > drivers/tty/serial/imx.c | 25 +++++++++++++------
> > > > 3 files changed, 32 insertions(+), 7 deletions(-)
> > >
> > > This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.
> > > You have sent him a patch that has triggered this response.
> > >
> > > Right now, the development tree you have sent a patch for is "closed"
> > > due to the timing of the merge window. Don't worry, the patch(es) you
> > > have sent are not lost, and will be looked at after the merge window is
> > > over (after the -rc1 kernel is released by Linus).
> > >
> > > So thank you for your patience and your patches will be reviewed at this
> > > later time, you do not have to do anything further, this is just a short
> > > note to let you know the patch status and so you don't worry they didn't
> > > make it through.
> > >
> > > thanks,
> > >
> > > greg k-h's patch email bot
> >
> > Any update on this? :)
>
> I'm waiting for the DT maintainers to review the new changes before I
> can take the driver changes.
I wonder what the DT maintainers said (and where [1]). The patch was
applied (db0a196bd8ad1d6bb4b1a9e54f54c09f8dc2cc25) and I think that's
wrong (as it was in v1) because fsl,dma-info isn't about hardware
description but about software tuning for different use cases.
Best regards
Uwe
[1] neither my mailbox nor lore.kernel.org know about an answer.
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-05 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 17:50 [PATCHv5 0/2] Fix imx53-ppd UART configuration Sebastian Reichel
2021-04-30 17:50 ` [PATCHv5 1/2] serial: imx: Add DMA buffer configuration via DT Sebastian Reichel
2021-04-30 17:50 ` [PATCHv5 2/2] ARM: dts: imx53-ppd: add dma-info nodes Sebastian Reichel
[not found] ` <YIzxKNV4x6/8GVrB@kroah.com>
2021-05-28 0:49 ` [PATCHv5 0/2] Fix imx53-ppd UART configuration Sebastian Reichel
2021-05-28 9:03 ` Greg Kroah-Hartman
2021-10-05 20:17 ` Uwe Kleine-König [this message]
2023-12-08 9:07 ` Uwe Kleine-König
2023-12-08 10:32 ` Greg Kroah-Hartman
2023-12-08 12:14 ` Krzysztof Kozlowski
2023-12-14 12:49 ` EXT: " Ian Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005201749.kpqkb5fxnavrqq2b@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).