* [PATCH net] net: mana: Fix error handling in mana_create_rxq()
@ 2021-10-07 22:45 Haiyang Zhang
2021-10-08 2:27 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Haiyang Zhang @ 2021-10-07 22:45 UTC (permalink / raw)
To: linux-hyperv, netdev
Cc: haiyangz, kys, sthemmin, paulros, shacharr, olaf, vkuznets,
davem, linux-kernel
Fix error handling in mana_create_rxq() when
cq->gdma_id >= gc->max_num_cqs.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 9a871192ca96..d65697c239c8 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -1477,8 +1477,10 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
if (err)
goto out;
- if (cq->gdma_id >= gc->max_num_cqs)
+ if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) {
+ err = -EINVAL;
goto out;
+ }
gc->cq_table[cq->gdma_id] = cq->gdma_cq;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: mana: Fix error handling in mana_create_rxq()
2021-10-07 22:45 [PATCH net] net: mana: Fix error handling in mana_create_rxq() Haiyang Zhang
@ 2021-10-08 2:27 ` Jakub Kicinski
2021-10-08 13:05 ` Haiyang Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2021-10-08 2:27 UTC (permalink / raw)
To: Haiyang Zhang
Cc: linux-hyperv, netdev, kys, sthemmin, paulros, shacharr, olaf,
vkuznets, davem, linux-kernel
On Thu, 7 Oct 2021 15:45:33 -0700 Haiyang Zhang wrote:
> Fix error handling in mana_create_rxq() when
> cq->gdma_id >= gc->max_num_cqs.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net] net: mana: Fix error handling in mana_create_rxq()
2021-10-08 2:27 ` Jakub Kicinski
@ 2021-10-08 13:05 ` Haiyang Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Haiyang Zhang @ 2021-10-08 13:05 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-hyperv, netdev, KY Srinivasan, Stephen Hemminger,
Paul Rosswurm, Shachar Raindel, olaf, vkuznets, davem,
linux-kernel
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, October 7, 2021 10:28 PM
> To: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; KY Srinivasan
> <kys@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>; Paul
> Rosswurm <paulros@microsoft.com>; Shachar Raindel
> <shacharr@microsoft.com>; olaf@aepfle.de; vkuznets <vkuznets@redhat.com>;
> davem@davemloft.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net] net: mana: Fix error handling in
> mana_create_rxq()
>
> On Thu, 7 Oct 2021 15:45:33 -0700 Haiyang Zhang wrote:
> > Fix error handling in mana_create_rxq() when
> > cq->gdma_id >= gc->max_num_cqs.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure
> Network Adapter (MANA)")
I will add "Fixes" line.
Thanks,
- Haiyang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-08 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 22:45 [PATCH net] net: mana: Fix error handling in mana_create_rxq() Haiyang Zhang
2021-10-08 2:27 ` Jakub Kicinski
2021-10-08 13:05 ` Haiyang Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).