[PATCH] mm/damon/dbgfs: add region_stat interface

* [PATCH] mm/damon/dbgfs: add region_stat interface
@ 2021-10-12  5:49 Xin Hao
  2021-10-12  7:11 ` SeongJae Park
  2021-10-12 17:16 ` kernel test robot
  0 siblings, 2 replies; 5+ messages in thread
From: Xin Hao @ 2021-10-12  5:49 UTC (permalink / raw)
  To: sjpark; +Cc: xhao, akpm, linux-mm, linux-kernel

Using damon-dbgfs has brought great convenience to user-mode
operation damon, but sometimes if i want to be able to view
the division of task regions, nr_access values etc,but i found
that it is impossible to view directly through the dbgfs interface,
so there i add a interface "region_stat", it displays like this.

 # cat region_stat
 last_aggregation=120.87s
 target_id=5148
 nr_regions=10
 400000-258c000(34352 KiB): 1
 258c000-4719000(34356 KiB): 0
 4719000-abbf000(103064 KiB): 0
 abbf000-c4d4000(25684 KiB): 11
 c4d4000-ff5c000(59936 KiB): 15
 ff5c000-152f9000(85620 KiB): 20
 152f9000-1599e000(6804 KiB): 10
 1599e000-19573000(61268 KiB): 0
 19573000-1f92c000(102116 KiB): 0
 1f92c000-22a4c000(50304 KiB): 0

Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
 mm/damon/dbgfs.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 58 insertions(+), 2 deletions(-)

diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index faee070977d8..269a336e92f0 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -266,6 +266,57 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file,
 	return len;
 }
 
+static ssize_t dbgfs_region_stat_read(struct file *file,
+		char __user *buf, size_t count, loff_t *ppos)
+{
+	struct damon_ctx *ctx = file->private_data;
+	struct damon_target *t;
+	char *kbuf;
+	ssize_t len;
+	int id, rc, written = 0;
+
+	kbuf = kmalloc(count, GFP_KERNEL);
+	if (!kbuf)
+		return -ENOMEM;
+
+	mutex_lock(&ctx->kdamond_lock);
+	damon_for_each_target(t, ctx) {
+		struct damon_region *r;
+
+		if (targetid_is_pid(ctx))
+			id = (int)pid_vnr((struct pid *)t->id);
+
+		rc = scnprintf(&kbuf[written], count - written,
+				"last_aggregation=%lld.%lds\ntarget_id=%d\nnr_regions=%u\n",
+				ctx->last_aggregation.tv_sec,
+				ctx->last_aggregation.tv_nsec / 1000000,
+				id, t->nr_regions);
+		if (!rc)
+			goto out;
+
+		written += rc;
+
+		damon_for_each_region(r, t) {
+			rc = scnprintf(&kbuf[written], count - written,
+				       "%lx-%lx(%lu KiB): %u\n",
+				       r->ar.start, r->ar.end,
+					   (r->ar.end - r->ar.start) >> 10,
+					   r->nr_accesses);
+			if (!rc)
+				goto out;
+
+			written += rc;
+		}
+
+		len += simple_read_from_buffer(buf, count, ppos, kbuf, written);
+	}
+
+out:
+	mutex_unlock(&ctx->kdamond_lock);
+	kfree(kbuf);
+	return len;
+}
+
 static int damon_dbgfs_open(struct inode *inode, struct file *file)
 {
 	file->private_data = inode->i_private;
@@ -290,12 +341,17 @@ static const struct file_operations kdamond_pid_fops = {
 	.read = dbgfs_kdamond_pid_read,
 };
 
+static const struct file_operations region_stat_fops = {
+	.open = damon_dbgfs_open,
+	.read = dbgfs_region_stat_read,
+};
+
 static void dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx)
 {
 	const char * const file_names[] = {"attrs", "target_ids",
-		"kdamond_pid"};
+		"kdamond_pid", "region_stat"};
 	const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops,
-		&kdamond_pid_fops};
+		&kdamond_pid_fops, &region_stat_fops};
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(file_names); i++)
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread