linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
	linux-kernel@vger.kernel.org (open list),
	laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl,
	kernel@collabora.com, dafna3@gmail.com,
	bob.beckett@collabora.com, kiril.bicevski@collabora.com,
	Nas Chung <nas.chung@chipsnmedia.com>,
	lafley.kim@chipsnmedia.com, scott.woo@chipsnmedia.com,
	olivier.crete@collabora.com
Subject: [PATCH v2 0/6] staging: media: wave5: add wave5 codec driver
Date: Wed, 13 Oct 2021 12:56:03 +0200	[thread overview]
Message-ID: <20211013105609.21457-1-dafna.hirschfeld@collabora.com> (raw)

The wave5 codec is a stateful encoder/decoder.
It is found on the JH7100 SoC.

The driver currently supports V4L2_PIX_FMT_HEVC, V4L2_PIX_FMT_H264.

This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV
board which uses the StarFive JH7100 beta SoC.

Testing on FPGA shows it working fine, though the FPGA uses polled interrupts
and copied buffers between the host and it's on board RAM.

Testing on BeagleV shows buffer corruption that is currently attributed to a
known silicon issue in the SoC that makes the cache coherent interconnect not
so coherent.
This can likely be solved when the riscv non-coherent dma support lands and
provide optional v4l2 non-contiguous allocator, though it remains to be seen
whether support non-coherent use cases will be useful in real world hw.

Until we can test and resolve any issues on final silicon (due 2H 2021)
this driver should remain in staging.

We currently tested only the decoder.
Testing the encoder is currently impossible because of the BeagleV buffer problems,
That will need to be tested once we have fixed beaglev buffer problems.

v4l2-compliance all pass for v2 as well.

changes since v1:

Fix chanes due to comments from Ezequiel and Dan Carpenter. Main fixes inclueds:
* move all files to one dir 'wave5'
* replace private error codes with standart error codes
* fix extra spaces
* various checkpatch fixes
* replace private 'DPRINTK' macro with standart 'dev_err/dbg ..'
* fix error handling
* add more possible fixes to the TODO file

Dafna Hirschfeld (4):
  staging: media: wave5: Add vpuapi layer
  staging: media: wave5: Add the vdi layer
  staging: media: wave5: Add the v4l2 layer
  staging: media: wave5: Add TODO file

Robert Beckett (2):
  dt-bindings: media: staging: wave5: add yaml devicetree bindings
  media: wave5: Add wave5 driver to maintainers file

 .../bindings/staging/media/cnm,wave.yaml      |   71 +
 MAINTAINERS                                   |    9 +
 drivers/staging/media/Kconfig                 |    2 +
 drivers/staging/media/Makefile                |    1 +
 drivers/staging/media/wave5/Kconfig           |   12 +
 drivers/staging/media/wave5/Makefile          |   10 +
 drivers/staging/media/wave5/TODO              |   58 +
 drivers/staging/media/wave5/vdi.c             |  260 ++
 drivers/staging/media/wave5/vdi.h             |   79 +
 drivers/staging/media/wave5/vpu.c             |  353 ++
 drivers/staging/media/wave5/vpu.h             |   63 +
 drivers/staging/media/wave5/vpu_dec.c         | 1400 +++++++
 drivers/staging/media/wave5/vpu_enc.c         | 1587 ++++++++
 drivers/staging/media/wave5/vpuapi.c          | 1096 +++++
 drivers/staging/media/wave5/vpuapi.h          | 1148 ++++++
 drivers/staging/media/wave5/vpuconfig.h       |   85 +
 drivers/staging/media/wave5/vpuerror.h        |  455 +++
 drivers/staging/media/wave5/wave5-hw.c        | 3513 +++++++++++++++++
 drivers/staging/media/wave5/wave5.h           |   80 +
 drivers/staging/media/wave5/wave5_regdefine.h |  638 +++
 20 files changed, 10920 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/staging/media/cnm,wave.yaml
 create mode 100644 drivers/staging/media/wave5/Kconfig
 create mode 100644 drivers/staging/media/wave5/Makefile
 create mode 100644 drivers/staging/media/wave5/TODO
 create mode 100644 drivers/staging/media/wave5/vdi.c
 create mode 100644 drivers/staging/media/wave5/vdi.h
 create mode 100644 drivers/staging/media/wave5/vpu.c
 create mode 100644 drivers/staging/media/wave5/vpu.h
 create mode 100644 drivers/staging/media/wave5/vpu_dec.c
 create mode 100644 drivers/staging/media/wave5/vpu_enc.c
 create mode 100644 drivers/staging/media/wave5/vpuapi.c
 create mode 100644 drivers/staging/media/wave5/vpuapi.h
 create mode 100644 drivers/staging/media/wave5/vpuconfig.h
 create mode 100644 drivers/staging/media/wave5/vpuerror.h
 create mode 100644 drivers/staging/media/wave5/wave5-hw.c
 create mode 100644 drivers/staging/media/wave5/wave5.h
 create mode 100644 drivers/staging/media/wave5/wave5_regdefine.h

-- 
2.17.1


             reply	other threads:[~2021-10-13 10:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 10:56 Dafna Hirschfeld [this message]
2021-10-13 10:56 ` [PATCH v2 1/6] staging: media: wave5: Add vpuapi layer Dafna Hirschfeld
2021-10-13 15:50   ` Dan Carpenter
2021-11-02 10:47     ` Dafna Hirschfeld
2021-11-05 14:21       ` Dan Carpenter
2021-10-13 10:56 ` [PATCH v2 2/6] staging: media: wave5: Add the vdi layer Dafna Hirschfeld
2021-10-13 10:56 ` [PATCH v2 3/6] staging: media: wave5: Add the v4l2 layer Dafna Hirschfeld
2021-10-13 15:25   ` Randy Dunlap
2021-10-14  1:54   ` kernel test robot
2021-10-13 10:56 ` [PATCH v2 4/6] staging: media: wave5: Add TODO file Dafna Hirschfeld
2021-10-13 10:56 ` [PATCH v2 5/6] dt-bindings: media: staging: wave5: add yaml devicetree bindings Dafna Hirschfeld
2021-10-13 10:56 ` [PATCH v2 6/6] media: wave5: Add wave5 driver to maintainers file Dafna Hirschfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211013105609.21457-1-dafna.hirschfeld@collabora.com \
    --to=dafna.hirschfeld@collabora.com \
    --cc=bob.beckett@collabora.com \
    --cc=dafna3@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=kiril.bicevski@collabora.com \
    --cc=lafley.kim@chipsnmedia.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=nas.chung@chipsnmedia.com \
    --cc=olivier.crete@collabora.com \
    --cc=scott.woo@chipsnmedia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).