Re: [PATCH v2 3/6] staging: media: wave5: Add the v4l2 layer

From: kernel test robot <lkp@intel.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Robert Beckett <bob.beckett@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	open list <linux-kernel@vger.kernel.org>,
	laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl,
	kernel@collabora.com
Subject: Re: [PATCH v2 3/6] staging: media: wave5: Add the v4l2 layer
Date: Thu, 14 Oct 2021 09:54:33 +0800	[thread overview]
Message-ID: <202110140940.Glga91d6-lkp@intel.com> (raw)
In-Reply-To: <20211013105609.21457-4-dafna.hirschfeld@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 3477 bytes --]

Hi Dafna,

I love your patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/staging-media-wave5-add-wave5-codec-driver/20211013-185733
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 98f668b30e8e65324b06332e9a3e2ea340bfd7f1
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd517a37be85a9497421e7ef39ca6b944d68089e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dafna-Hirschfeld/staging-media-wave5-add-wave5-codec-driver/20211013-185733
        git checkout fd517a37be85a9497421e7ef39ca6b944d68089e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/staging/media/wave5/wave5-hw.c:240:5: error: no previous prototype for 'setup_wave5_properties' [-Werror=missing-prototypes]
     240 | int setup_wave5_properties(struct device *dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   drivers/staging/media/wave5/vpu_dec.c: In function 'wave5_vpu_dec_release':
>> drivers/staging/media/wave5/vpu_dec.c:1323:21: error: variable 'ret' set but not used [-Werror=unused-but-set-variable]
    1323 |                 int ret;
         |                     ^~~
   cc1: all warnings being treated as errors

vim +/ret +1323 drivers/staging/media/wave5/vpu_dec.c

  1314	
  1315	static int wave5_vpu_dec_release(struct file *filp)
  1316	{
  1317		int i;
  1318		struct vpu_instance *inst = wave5_to_vpu_inst(filp->private_data);
  1319		unsigned int loop_count = 0;
  1320	
  1321		v4l2_m2m_ctx_release(inst->v4l2_fh.m2m_ctx);
  1322		if (inst->state != VPU_INST_STATE_NONE) {
> 1323			int ret;
  1324			u32 fail_res = 0;
  1325	
  1326			ret = wave5_vpu_dec_close(inst, &fail_res);
  1327			while (fail_res == WAVE5_SYSERR_VPU_STILL_RUNNING) {
  1328				if (wave5_vpu_wait_interrupt(inst, VPU_DEC_TIMEOUT) < 0) {
  1329					dev_dbg(inst->dev->dev, "failed to call vpu_wait_interrupt()\n");
  1330					if (loop_count < 10) {
  1331						loop_count++;
  1332						continue;
  1333					} else {
  1334						dev_dbg(inst->dev->dev, "failed wave5_vpu_dec_close()\n");
  1335						break;
  1336					}
  1337				} else {
  1338					break;
  1339				}
  1340				fail_res = 0;
  1341				ret = wave5_vpu_dec_close(inst, &fail_res);
  1342			}
  1343		}
  1344		for (i = 0; i < inst->min_dst_frame_buf_count; i++) {
  1345			if (inst->frame_vbuf[i].size != 0)
  1346				wave5_vdi_free_dma_memory(inst->dev, &inst->frame_vbuf[i]);
  1347		}
  1348		if (inst->bitstream_vbuf.size != 0)
  1349			wave5_vdi_free_dma_memory(inst->dev, &inst->bitstream_vbuf);
  1350		v4l2_ctrl_handler_free(&inst->v4l2_ctrl_hdl);
  1351		v4l2_fh_del(&inst->v4l2_fh);
  1352		v4l2_fh_exit(&inst->v4l2_fh);
  1353		kfree(inst);
  1354	
  1355		return 0;
  1356	}
  1357	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69175 bytes --]