* [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON
@ 2021-10-13 14:38 Arnd Bergmann
2021-10-13 15:00 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:38 UTC (permalink / raw)
To: Lorenzo Pieralisi, Bjorn Helgaas
Cc: Arnd Bergmann, Rob Herring, Krzysztof Wilczyński,
Marc Zyngier, Alyssa Rosenzweig, Sven Peter, linux-pci,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
If this symbol is not already selected by another driver, pci-apple.o
fails to link:
aarch64-linux-ld: drivers/pci/controller/pcie-apple.o: in function `apple_pcie_probe':
pcie-apple.c:(.text+0xd28): undefined reference to `pci_host_common_probe'
Add another 'select' statement here, the same that is used for the
other drivers.
Fixes: a8bbe0366a3e ("PCI: apple: Add initial hardware bring-up")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/controller/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index cc1fcc89c58f..5af99701e1f6 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -322,6 +322,7 @@ config PCIE_APPLE
depends on ARCH_APPLE || COMPILE_TEST
depends on OF
depends on PCI_MSI_IRQ_DOMAIN
+ select PCI_HOST_COMMON
help
Say Y here if you want to enable PCIe controller support on Apple
system-on-chips, like the Apple M1. This is required for the USB
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON
2021-10-13 14:38 [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON Arnd Bergmann
@ 2021-10-13 15:00 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-13 15:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Helgaas, Arnd Bergmann, Rob Herring,
Krzysztof Wilczyński, Marc Zyngier, Alyssa Rosenzweig,
Sven Peter, linux-pci, linux-kernel
On Wed, Oct 13, 2021 at 04:38:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If this symbol is not already selected by another driver, pci-apple.o
> fails to link:
>
> aarch64-linux-ld: drivers/pci/controller/pcie-apple.o: in function `apple_pcie_probe':
> pcie-apple.c:(.text+0xd28): undefined reference to `pci_host_common_probe'
>
> Add another 'select' statement here, the same that is used for the
> other drivers.
>
> Fixes: a8bbe0366a3e ("PCI: apple: Add initial hardware bring-up")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/controller/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Squashed it in the commit it is fixing and rebuilt my pci/apple
branch.
Thanks,
Lorenzo
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index cc1fcc89c58f..5af99701e1f6 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -322,6 +322,7 @@ config PCIE_APPLE
> depends on ARCH_APPLE || COMPILE_TEST
> depends on OF
> depends on PCI_MSI_IRQ_DOMAIN
> + select PCI_HOST_COMMON
> help
> Say Y here if you want to enable PCIe controller support on Apple
> system-on-chips, like the Apple M1. This is required for the USB
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-13 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 14:38 [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON Arnd Bergmann
2021-10-13 15:00 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).