* [PATCH] video: omapfb: Fix fall-through warning for Clang
@ 2021-10-14 16:53 Gustavo A. R. Silva
[not found] ` <YWh2bKnY0Z75g0S3@ravnborg.org>
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2021-10-14 16:53 UTC (permalink / raw)
To: linux-fbdev, linux-omap, dri-devel, linux-kernel,
Gustavo A. R. Silva, linux-hardening,
Fix the following fallthrough warnings:
drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case 0:
^
drivers/video/fbdev/omap/omapfb_main.c:1558:2: note: insert 'break;' to avoid fall-through
case 0:
^
break;
1 warning generated.
This helps with the ongoing efforts to globally enable
-Wimplicit-fallthrough for Clang.
Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/lkml/202110141005.hUjaYMEi-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/video/fbdev/omap/omapfb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 3d090d2d9ed9..b495c09e6102 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1555,6 +1555,7 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
case 1:
dev_set_drvdata(fbdev->dev, NULL);
kfree(fbdev);
+ break;
case 0:
/* nothing to free */
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: omapfb: Fix fall-through warning for Clang
[not found] ` <YWh2bKnY0Z75g0S3@ravnborg.org>
@ 2021-10-14 18:34 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2021-10-14 18:34 UTC (permalink / raw)
To: Sam Ravnborg
Cc: linux-fbdev, linux-omap, dri-devel, linux-kernel, linux-hardening,
On Thu, Oct 14, 2021 at 08:26:52PM +0200, Sam Ravnborg wrote:
> Hi Gustavo,
> On Thu, Oct 14, 2021 at 11:53:20AM -0500, Gustavo A. R. Silva wrote:
> > Fix the following fallthrough warnings:
> >
> > drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> > case 0:
> > ^
> > drivers/video/fbdev/omap/omapfb_main.c:1558:2: note: insert 'break;' to avoid fall-through
> > case 0:
> > ^
> > break;
> > 1 warning generated.
> >
> > This helps with the ongoing efforts to globally enable
> > -Wimplicit-fallthrough for Clang.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Link: https://lore.kernel.org/lkml/202110141005.hUjaYMEi-lkp@intel.com/
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> applied to drm-misc-next. It will show up in -next in 1-2 weeks time.
Great. :)
Thanks, Sam.
--
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-14 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14 16:53 [PATCH] video: omapfb: Fix fall-through warning for Clang Gustavo A. R. Silva
[not found] ` <YWh2bKnY0Z75g0S3@ravnborg.org>
2021-10-14 18:34 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).