* [PATCH v2] usb: typec: STUSB160X should select REGMAP_I2C
@ 2021-10-15 1:36 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2021-10-15 1:36 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Heikki Krogerus, Amelie Delaunay,
Greg Kroah-Hartman, linux-usb, Amelie Delaunay
REGMAP_I2C is not a user visible kconfig symbol so driver configs
should not "depend on" it. They should depend on I2C and then
select REGMAP_I2C.
If this worked, it was only because some other driver had set/enabled
REGMAP_I2C.
Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Amelie Delaunay <amelie.delaunay@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
v2: add Reviewed-by: tags
rebase and resend
add patch dependency (below)
This patch depends on this patch that is in usb-next:
[PATCH] usb: musb: select GENERIC_PHY instead of depending on it
lore.kernel.org/r/20211005235747.5588-1-rdunlap@infradead.org
drivers/usb/typec/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20211013.orig/drivers/usb/typec/Kconfig
+++ linux-next-20211013/drivers/usb/typec/Kconfig
@@ -65,9 +65,9 @@ config TYPEC_HD3SS3220
config TYPEC_STUSB160X
tristate "STMicroelectronics STUSB160x Type-C controller driver"
- depends on I2C
- depends on REGMAP_I2C
depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
+ depends on I2C
+ select REGMAP_I2C
help
Say Y or M here if your system has STMicroelectronics STUSB160x
Type-C port controller.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-15 1:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 1:36 [PATCH v2] usb: typec: STUSB160X should select REGMAP_I2C Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).